Re: [PATCH v5 3/3] arm64: dts: rockchip: Add Orange Pi 5 Pro board support

[Dennis Gilmore]

Hi Andrew,

On Wed, Apr 1, 2026 at 6:56 AM Andrew Lunn <andrew@xxxxxxx> wrote:
>
> On Tue, Mar 31, 2026 at 08:07:07PM -0500, dennis@xxxxxxxx wrote:
> > From: Dennis Gilmore <dennis@xxxxxxxx>
> >
> > Add device tree for the Xunlong Orange Pi 5 Pro (RK3588S).
> >
> > - eMMC module, you can optionally solder a SPI NOR in place and turn
> >  off the eMMC
> > - PCIe-attached NIC (pcie2x1l1)
> > - PCIe NVMe slot (pcie2x1l2)
> > - AP6256 WiFi (BCM43456) via SDIO with mmc-pwrseq
> > - BCM4345C5 Bluetooth
> > - es8388 audio
> > - USB 2.0 and USB 3.0
>
> You said in patch 0/X that the Ethernet driver had just been
> accepted. So i was expecting a node for it here?
>
>           Andrew

On the Orange Pi 5 Pro, Ethernet is connected to PCIe; there is no
need to define anything

Dennis