Re: [PATCH v3 7/7] dt-bindings: PCI: intel,lgm-pcie: Add atu resource

[Florian Eckert]

On 2026-04-01 15:07, Rob Herring wrote:
> On Wed, Apr 1, 2026 at 5:37 AM Rob Herring (Arm) <robh@xxxxxxxxxx> 
> wrote:
> > On Wed, 01 Apr 2026 11:31:43 +0200, Florian Eckert wrote:
> > > The 'atu' information is already set in the dwc core, if it is specified
> > > in the devicetree. The driver uses its own default, if not set in the
> > > devicetree. This information is hardware specific and should therefore be
> > > maintained in the devicetree rather than in the source.
> > >
> > > To be backward compatibile, this field is not mandatory. If 'atu'
> > > resource is not specified in the devicetree, the driver’s default value
> > > is used.
> > >
> > > Old DTS entry for PCIe:
> > >
> > > reg = <0xd1000000 0x1000>,
> > >       <0xd3000000 0x20000>,
> > >       <0xd0c41000.0x1000>;
> > > reg-names = "dbi", "config", "app";
> > >
> > > New DTS entry for PCIe:
> > >
> > > reg = <0xd1000000 0x1000>,
> > >       <0xd10c0000 0x1000>,
> > >       <0xd3000000 0x20000>,
> > >      <0xd0c41000.0x1000>;
> > > reg-names = "dbi", "atu", "config", "app";
>
> This is also wrong. But the diff of the example shows the old vs. new,
> so there's really no reason for any of this in the commit msg.

Got it. Thanks for pointing that out. I’ve already removed it for the
next cycle for the v4.

--
Florian

> > >
> > > Signed-off-by: Florian Eckert <fe@xxxxxxxxxx>
> > > ---
> > >  Documentation/devicetree/bindings/pci/intel-gw-pcie.yaml | 6 +++++-
> > >  1 file changed, 5 insertions(+), 1 deletion(-)
> > >
> >
> > My bot found errors running 'make dt_binding_check' on your patch:
> >
> > yamllint warnings/errors:
> >
> > dtschema/dtc warnings/errors:
> > /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/pci/intel-gw-pcie.example.dtb: 
> > pcie@d0e00000 (intel,lgm-pcie): reg-names:1: 'config' was expected
> >         from schema $id: 
> > http://devicetree.org/schemas/pci/intel-gw-pcie.yaml
> > /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/pci/intel-gw-pcie.example.dtb: 
> > pcie@d0e00000 (intel,lgm-pcie): reg-names:2: 'app' was expected
> >         from schema $id: 
> > http://devicetree.org/schemas/pci/intel-gw-pcie.yaml
> > /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/pci/intel-gw-pcie.example.dtb: 
> > pcie@d0e00000 (intel,lgm-pcie): reg-names:3: 'atu' was expected
> >         from schema $id: 
> > http://devicetree.org/schemas/pci/intel-gw-pcie.yaml
> >
> > doc reference errors (make refcheckdocs):
> >
> > See 
> > https://patchwork.kernel.org/project/devicetree/patch/20260401-pcie-intel-gw-v3-7-63b008c5b7b2@xxxxxxxxxx
> >
> > The base for the series is generally the latest rc1. A different 
> > dependency
> > should be noted in *this* patch.
> >
> > If you already ran 'make dt_binding_check' and didn't see the above
> > error(s), then make sure 'yamllint' is installed and dt-schema is up 
> > to
> > date:
> >
> > pip3 install dtschema --upgrade
> >
> > Please check and re-submit after running the above command yourself. 
> > Note
> > that DT_SCHEMA_FILES can be set to your schema file to speed up 
> > checking
> > your schema. However, it must be unset to test all examples with your 
> > schema.