Re: [PATCH] cpufreq: cleanup dead code in Kconfig

[Rafael J. Wysocki]

On Tue, Mar 31, 2026 at 9:55 AM Viresh Kumar <viresh.kumar@xxxxxxxxxx> wrote:
>
> On 31-03-26, 08:42, Julian Braha wrote:
> > There is already an 'if CPU_FREQ' condition wrapping these config
> > options, making the 'depends on' statement for each a duplicate
> > dependency (dead code).
> >
> > I propose leaving the outer 'if CPU_FREQ...endif' and
> > removing the individual 'depends on' statement from each option.
> >
> > This dead code was found by kconfirm, a static analysis tool for Kconfig.
> >
> > Signed-off-by: Julian Braha <julianbraha@xxxxxxxxx>
> > ---
> >  drivers/cpufreq/Kconfig | 5 ++---
> >  1 file changed, 2 insertions(+), 3 deletions(-)
> >
> > diff --git a/drivers/cpufreq/Kconfig b/drivers/cpufreq/Kconfig
> > index 78702a08364f..db83f3365698 100644
> > --- a/drivers/cpufreq/Kconfig
> > +++ b/drivers/cpufreq/Kconfig
> > @@ -163,7 +163,6 @@ config CPU_FREQ_GOV_ONDEMAND
> >
> >  config CPU_FREQ_GOV_CONSERVATIVE
> >       tristate "'conservative' cpufreq governor"
> > -     depends on CPU_FREQ
> >       select CPU_FREQ_GOV_COMMON
> >       help
> >         'conservative' - this driver is rather similar to the 'ondemand'
> > @@ -188,7 +187,7 @@ config CPU_FREQ_GOV_CONSERVATIVE
> >
> >  config CPU_FREQ_GOV_SCHEDUTIL
> >       bool "'schedutil' cpufreq policy governor"
> > -     depends on CPU_FREQ && SMP
> > +     depends on SMP
> >       select CPU_FREQ_GOV_ATTR_SET
> >       select IRQ_WORK
> >       help
> > @@ -365,6 +364,6 @@ config ACPI_CPPC_CPUFREQ_FIE
> >
> >         If in doubt, say N.
> >
> > -endif
> > +endif # CPU_FREQ
> >
> >  endmenu
>
> Acked-by: Viresh Kumar <viresh.kumar@xxxxxxxxxx>

Applied as 7.1 material, thanks!