Re: [PATCH v6] staging: media: atomisp: fix GP_TIMER_BASE scope in gp_timer.c

[Anushka B]

Hi Sakari,

On Wed, Apr 1, 2026 at 12:25 PM Sakari Ailus
<sakari.ailus@xxxxxxxxxxxxxxx> wrote:
>
> On Mon, Mar 30, 2026 at 07:02:21AM +0530, Anushka B wrote:
> > > There's a lot to cleanup here, but what should be done is roughly:
> > >
> > > - Make these constants macros (with IPU2_ or ATOMISP2_ prefix?) and move
> > >   them into a separate header (perhaps with register definitions?).
> > >
> > > - Remove my_env and make struct device (or maybe struct atomisp_device?) as
> > >   a parameter for register access functions.
> > >
> > > This may get a bit complicated due to the amount of cleanup needed so
> > > having the hardware for testing would be rather essential.
> > As a student, I don't currently have access to the hardware needed to
> > do the bigger refactor safely. However I'm happy to fix the comment
> > formatting and language.
> > In earlier versions, I had merged the split declaration of
> > GP_TIMER_BASE in place in system_local.c before later moving it to
> > gp_timer.c.
> > Link: https://lore.kernel.org/linux-media/20260325132434.55775-1-anushkabadhe@xxxxxxxxx/
> > Would it be okay to proceed with the simpler in-place fix for
> > GP_TIMER_BASE declaration instead?
>
> I'm fine with v4.

Should I send a v7 similar to v4, where I merged the split declaration
of GP_TIMER_BASE, and a separate patch for the comment fixes?

Thanks,
Anushka