Re: [PATCH 7/7] clk: qcom: Add support for global clock controller on Hawi

[Mike Tipton]

On Tue, Mar 31, 2026 at 04:11:22PM -0500, Bjorn Andersson wrote:
> On Mon, Mar 30, 2026 at 05:35:02PM -0700, Vivek Aknurwar wrote:
> > +++ b/drivers/clk/qcom/gcc-hawi.c
> [..]
> > +static const struct qcom_cc_desc gcc_hawi_desc = {
> > +	.config = &gcc_hawi_regmap_config,
> > +	.clks = gcc_hawi_clocks,
> > +	.num_clks = ARRAY_SIZE(gcc_hawi_clocks),
> > +	.resets = gcc_hawi_resets,
> > +	.num_resets = ARRAY_SIZE(gcc_hawi_resets),
> > +	.gdscs = gcc_hawi_gdscs,
> > +	.num_gdscs = ARRAY_SIZE(gcc_hawi_gdscs),
> > +	.driver_data = &gcc_hawi_driver_data,
> 
> Sorry for not spotting this earlier, but don't we need a ".use_rpm =
> true" here?
> 
> In line with
> https://lore.kernel.org/all/20260309-glymur-fix-gcc-cx-scaling-v2-2-d7a58a0a9ecb@xxxxxxxxxxxxxxxx/

Yeah, we should. Same rationale, which technically applies to many other
GCC instances that aren't setting this today.

Mike

> 
> Regards,
> Bjorn
> 
> > +};
> > +