Re: [PATCH v4 11/13] ext4: remove ctime/mtime update from ext4_alloc_file_blocks()

[Jan Kara]

On Fri 27-03-26 18:29:37, Zhang Yi wrote:
> From: Zhang Yi <yi.zhang@xxxxxxxxxx>
> 
> The ctime and mtime update is already handled by file_modified() in
> ext4_fallocate(), the caller of ext4_alloc_file_blocks(). So remove the
> redundant calls to inode_set_ctime_current() and inode_set_mtime_to_ts()
> in ext4_alloc_file_blocks().
> 
> Signed-off-by: Zhang Yi <yi.zhang@xxxxxxxxxx>

Looks good. Feel free to add:

Reviewed-by: Jan Kara <jack@xxxxxxx>

								Honza

> ---
>  fs/ext4/extents.c | 5 +----
>  1 file changed, 1 insertion(+), 4 deletions(-)
> 
> diff --git a/fs/ext4/extents.c b/fs/ext4/extents.c
> index f4009544f762..7abe47f923c0 100644
> --- a/fs/ext4/extents.c
> +++ b/fs/ext4/extents.c
> @@ -4623,13 +4623,10 @@ static int ext4_alloc_file_blocks(struct file *file, loff_t offset, loff_t len,
>  		 */
>  		retries = 0;
>  		epos = EXT4_LBLK_TO_B(inode, map.m_lblk + ret);
> -		inode_set_ctime_current(inode);
>  		if (new_size) {
>  			if (epos > new_size)
>  				epos = new_size;
> -			if (ext4_update_inode_size(inode, epos) & 0x1)
> -				inode_set_mtime_to_ts(inode,
> -						      inode_get_ctime(inode));
> +			ext4_update_inode_size(inode, epos);
>  			if (epos > old_size)
>  				pagecache_isize_extended(inode, old_size, epos);
>  		}
> -- 
> 2.52.0
> 
-- 
Jan Kara <jack@xxxxxxxx>
SUSE Labs, CR