Re: [PATCH v1] perf: Make more global variables static

[Arnaldo Carvalho de Melo]

On Tue, Mar 31, 2026 at 10:15:16PM -0700, Ian Rogers wrote:
> On Tue, Jan 13, 2026 at 1:40 PM Arnaldo Carvalho de Melo
> <acme@xxxxxxxxxx> wrote:
> >
> > On Fri, Jan 09, 2026 at 05:36:54PM -0800, Namhyung Kim wrote:
> > > On Thu, Dec 04, 2025 at 01:42:35PM -0800, Ian Rogers wrote:
> > > > `make check` will run sparse on the perf code base. A frequent warning
> > > > is "warning: symbol '...' was not declared. Should it be static?" Go
> > > > through and make global definitions without declarations static. In
> > > > some cases it is deliberate due to dlsym accessing the symbol, this
> > > > change doesn't clean up the missing declarations for perf test
> > > > suites. Sometimes things can opportunistically be made const. Making
> > > > somethings static exposed unused functions warnings, so restructuring
> > > > of ifdefs was necessary for that. These changes reduce the size of the
> > > > perf binary by 3,264 bytes.
> > > >
> > > > Signed-off-by: Ian Rogers <irogers@xxxxxxxxxx>
> > >
> > > Acked-by: Namhyung Kim <namhyung@xxxxxxxxxx>
> >
> > Thanks, applied to perf-tools-next,
> 
> Hi Arnaldo, it looks like this patch got lost. I'm not seeing it in
> perf-tools-next. I suspect it needs a hefty rebase now. Any idea what
> happened?

I think there was some issue and I removed it to make progress, then
fell thru the cracks.

I refreshed it, see below, will send together with a few other patches
after testing it in the build containers.

There were just a few adjustments and a lot of fuzz the perf regs part
you refactored, etc.

Thanks for the reminder and sorry about it,

- Arnaldo