Re: [PATCH v3 2/2] dmaengine: xilinx_dma: Rename XILINX_DMA_LOOP_COUNT

[Frank Li]

On Wed, Apr 01, 2026 at 12:56:33PM +0200, Alex Bereza wrote:
> Rename XILINX_DMA_LOOP_COUNT to XILINX_DMA_POLL_TIMEOUT_US because the
> former is incorrect. It is a timeout value for polling various register
> bits in microseconds. It is not a loop count.

Rename XILINX_DMA_LOOP_COUNT to XILINX_DMA_POLL_TIMEOUT_US because it is a
timeout value, not a loop count for polling register in microseconds.

No functional changes.

Frank

>
> Signed-off-by: Alex Bereza <alex@bereza.email>
> ---
>  drivers/dma/xilinx/xilinx_dma.c | 12 ++++++------
>  1 file changed, 6 insertions(+), 6 deletions(-)
>
> diff --git a/drivers/dma/xilinx/xilinx_dma.c b/drivers/dma/xilinx/xilinx_dma.c
> index 345a738bab2c..253c27fd1a0e 100644
> --- a/drivers/dma/xilinx/xilinx_dma.c
> +++ b/drivers/dma/xilinx/xilinx_dma.c
> @@ -165,8 +165,8 @@
>  #define XILINX_DMA_FLUSH_MM2S		2
>  #define XILINX_DMA_FLUSH_BOTH		1
>
> -/* Delay loop counter to prevent hardware failure */
> -#define XILINX_DMA_LOOP_COUNT		1000000
> +/* Timeout for polling various registers */
> +#define XILINX_DMA_POLL_TIMEOUT_US	1000000
>  /* Delay between polls (avoid a delay of 0 to prevent CPU stalls) */
>  #define XILINX_DMA_POLL_DELAY_US	10
>
> @@ -1336,7 +1336,7 @@ static int xilinx_dma_stop_transfer(struct xilinx_dma_chan *chan)
>  	return xilinx_dma_poll_timeout(chan, XILINX_DMA_REG_DMASR, val,
>  				       val & XILINX_DMA_DMASR_HALTED,
>  				       XILINX_DMA_POLL_DELAY_US,
> -				       XILINX_DMA_LOOP_COUNT);
> +				       XILINX_DMA_POLL_TIMEOUT_US);
>  }
>
>  /**
> @@ -1352,7 +1352,7 @@ static int xilinx_cdma_stop_transfer(struct xilinx_dma_chan *chan)
>  	return xilinx_dma_poll_timeout(chan, XILINX_DMA_REG_DMASR, val,
>  				       val & XILINX_DMA_DMASR_IDLE,
>  				       XILINX_DMA_POLL_DELAY_US,
> -				       XILINX_DMA_LOOP_COUNT);
> +				       XILINX_DMA_POLL_TIMEOUT_US);
>  }
>
>  /**
> @@ -1370,7 +1370,7 @@ static void xilinx_dma_start(struct xilinx_dma_chan *chan)
>  	err = xilinx_dma_poll_timeout(chan, XILINX_DMA_REG_DMASR, val,
>  				      !(val & XILINX_DMA_DMASR_HALTED),
>  				      XILINX_DMA_POLL_DELAY_US,
> -				      XILINX_DMA_LOOP_COUNT);
> +				      XILINX_DMA_POLL_TIMEOUT_US);
>
>  	if (err) {
>  		dev_err(chan->dev, "Cannot start channel %p: %x\n",
> @@ -1787,7 +1787,7 @@ static int xilinx_dma_reset(struct xilinx_dma_chan *chan)
>  	err = xilinx_dma_poll_timeout(chan, XILINX_DMA_REG_DMACR, tmp,
>  				      !(tmp & XILINX_DMA_DMACR_RESET),
>  				      XILINX_DMA_POLL_DELAY_US,
> -				      XILINX_DMA_LOOP_COUNT);
> +				      XILINX_DMA_POLL_TIMEOUT_US);
>
>  	if (err) {
>  		dev_err(chan->dev, "reset timeout, cr %x, sr %x\n",
>
> --
> 2.53.0
>