Re: [PATCH 13/17] KVM: TDX: Hoist tdx_sept_remove_private_spte() above set_private_spte()
From: Edgecombe, Rick P
Date: Wed Apr 01 2026 - 20:05:26 EST
On Tue, 2026-03-31 at 10:42 +0000, Huang, Kai wrote:
> On Fri, 2026-03-27 at 13:14 -0700, Rick Edgecombe wrote:
> > From: Sean Christopherson <seanjc@xxxxxxxxxx>
> >
> > Move tdx_sept_remove_private_spte() (and its tdx_track() helper) above
> > tdx_sept_set_private_spte() in anticipation of routing all non-atomic
> > S-EPT writes (with the exception of reclaiming non-leaf pages) through
> > the "set" API.
>
> The diff reads more like moving tdx_sept_set_private_spte() down, though.
Yea I noticed that too. We can make it more generic, like "arrange such that..."