Re: [PATCH] ata: libata-eh: Do not retry reset if the device is gone

From: Damien Le Moal

Date: Thu Apr 02 2026 - 01:26:09 EST


On 2026/04/02 10:11, Igor Pylypiv wrote:
> If a device is hot-unplugged or otherwise disappears during error handling,
> ata_eh_reset() may fail with -ENODEV. Currently, the error handler will
> continue to retry the reset operation up to max_tries times.
>
> Prevent unnecessary reset retries by exiting the loop early when
> ata_eh_reset() returns -ENODEV.
>
> Signed-off-by: Igor Pylypiv <ipylypiv@xxxxxxxxxx>

Looks good.

Reviewed-by: Damien Le Moal <dlemoal@xxxxxxxxxx>

--
Damien Le Moal
Western Digital Research