Re: [PATCH] ata: pata_arasan_cf: fix missing newline in dev_err messages

[Owens James]

Hi Damien,

Thank you for checking!
The function arasan_cf_xfer() does exist in the mainline kernel at
drivers/ata/pata_arasan_cf.c around line 380.
This patch is based on the latest upstream mainline branch.
Please let me know if you need anything else.

Best regards, Haoyu Lu

Damien Le Moal <dlemoal@xxxxxxxxxx> 于2026年4月2日周四 13:35写道：
>
> On 2026/04/02 11:10, Haoyu Lu wrote:
> > Add missing trailing newlines to dev_err() messages in pata_arasan_cf.c.
> >
> > This keeps the error output as properly terminated log lines.
> >
> > Signed-off-by: Haoyu Lu <hechushiguitu666@xxxxxxxxx>
> > ---
> >  drivers/ata/pata_arasan_cf.c | 4 ++--
> >  1 file changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/drivers/ata/pata_arasan_cf.c b/drivers/ata/pata_arasan_cf.c
> > index 514d549286b5..abcdef123456 100644
> > --- a/drivers/ata/pata_arasan_cf.c
> > +++ b/drivers/ata/pata_arasan_cf.c
> > @@ -380,7 +380,7 @@ static int arasan_cf_xfer(struct arasan_cf_dev *acdev, struct ata_queued_cmd *qc
>
> There is no such function, and yet your patch applies. I am confused...
> Which tree is this patch against ?
>
> >       if (!wait_for_completion_timeout(&acdev->cf_completion, TIMEOUT)) {
> >               u32 rw = acdev->qc->tf.flags & ATA_TFLAG_WRITE;
> >
> > -             dev_err(acdev->host->dev, "%s TimeOut", rw ? "write" : "read");
> > +             dev_err(acdev->host->dev, "%s TimeOut\n", rw ? "write" : "read");
> >               return -ETIMEDOUT;
> >       }
> >
> > @@ -474,7 +474,7 @@ static int arasan_cf_xfer(struct arasan_cf_dev *acdev, struct ata_queued_cmd *qc
> >                       dma_len = min(xfer_cnt, FIFO_SIZE);
> >                       ret = dma_xfer(acdev, src, dest, dma_len);
> >                       if (ret) {
> > -                             dev_err(acdev->host->dev, "dma failed");
> > +                             dev_err(acdev->host->dev, "dma failed\n");
> >                               goto fail;
> >                       }
> >
> > --
> > 2.17.1
>
>
> --
> Damien Le Moal
> Western Digital Research