Re: [PATCH v2] staging: rtl8723bs: remove GEN_CMD_CODE macro and callback array

[Bera Yüzlü]

On Wed,  1 Apr 2026 22:35:59 -0400, Xiyuan Guo wrote:
> The GEN_CMD_CODE macro and the rtw_cmd_callback function pointer array
> add unnecessary layers of indirection and make the code difficult to
> follow. Remove the GEN_CMD_CODE macro and replace the function pointer array
> dispatcher in rtw_cmd_thread() with a direct switch statement.
> 
> Additionally, rename the associated command enums from CamelCase to
> UPPERCASE_SNAKE_CASE to comply with the standard Linux kernel coding
> style.
> 
> Signed-off-by: Xiyuan Guo <tommyguo039@xxxxxxxxx>
> ---

...

> -#endif /*  _CMD_H_ */
> +#endif /* _CMD_H_ */

This must be __RTW_CMD_H_ but it is competely unrelated with this patch.
If you want to fix this you can send a separate patch.

Thanks,
Bera