Re: [PATCH] HID: gpd: fix report descriptor on GPD Win handheld (2f24:0137)

From: Jiri Kosina

Date: Thu Apr 02 2026 - 03:59:08 EST


On Wed, 1 Apr 2026, Denis Benato wrote:

> > Hmmm, why does this need to be a config option? Can't this be enabled
> > unconditionally? I ask in general, as it's just another point where
> > things can go wrong. But I mainly ask because it's a regression fix –
> > and from my understanding wrt to what Linus wants we don't expect users
> > to turn some .config on to keep their hardware running (unless it can't
> > be avoided at all costs).
> >
> > Ciao, Thorsten
> >
> Perhaps the place of this, just for affected kernel series that are out
> (assuming stable has the bug, I haven't checked) is to do this on hid-generic,
> otherwise it's a change of driver managing the device?

The problem is that the device has a broken (violating spec) report
descriptor.

We got away from it before the change, but with more sanitization having
been put in place in order to deal with potentially malicious devices,
this device (correctly, in some sense), stopped working.

The way around it is to replace the report descriptor with a fixed one.
And we do it with a specific driver for now (there have been other
proposals, like request_firmware(), or it could eventually be done from
userspace / BPF, but none of it hasn't been yet implemented).

I have also been thinking about having a config option that'd link all the
HID drivers into one huge hid.ko blob for those scenarios where people
don't care about memory / disk footprint, and want everything to "just
work" automatically (thinking of distro kernels, for example).

--
Jiri Kosina
SUSE Labs