Re: [PATCH] ata: pata_arasan_cf: fix missing newline in dev_err messages

[Haoyu Lu]

Hi Damien,

Sorry for the mistake!
I didn't realize libata patches need to be based on libata/for-next,
not mainline.
I see the driver has been refactored and the newlines are already fixed.
I'll drop this patch and follow the correct branch for future changes.
Thanks for the clarification!

Best regards, Haoyu Lu

On Thu, Apr 2, 2026 at 3:38 PM Damien Le Moal <dlemoal@xxxxxxxxxx> wrote:
>
> On 2026/04/02 16:11, Owens James wrote:
> > Hi Damien,
> >
> > Thank you for checking!
> > The function arasan_cf_xfer() does exist in the mainline kernel at
> > drivers/ata/pata_arasan_cf.c around line 380.
>
> Nope...
>
> 378 static inline int wait4buf(struct arasan_cf_dev *acdev)
> 379 {
> 380         if (!wait_for_completion_timeout(&acdev->cf_completion, TIMEOUT)) {
> 381                 u32 rw = acdev->qc->tf.flags & ATA_TFLAG_WRITE;
> 382
> 383                 dev_err(acdev->host->dev, "%s TimeOut\n", rw ? "write" :
> "read");
> 384                 return -ETIMEDOUT;
> 385         }
> 386
> 387         /* Check if PIO Error interrupt has occurred */
> 388         if (acdev->dma_status & ATA_DMA_ERR)
> 389                 return -EAGAIN;
> 390
> 391         return 0;
> 392 }
>
> And "git grep arasan_cf_xfer" gives nothing.
>
> So still not sure which kernel you are looking at.
>
> > This patch is based on the latest upstream mainline branch.
> > Please let me know if you need anything else.
>
> Patches for libata should be based off libata/for-next or libata/for-7.1.
>
>
> --
> Damien Le Moal
> Western Digital Research