Re: [PATCH v2 05/10] drm/bridge: dw-hdmi: document the output_port field

[Damon Ding]

Hi Luca,

On 4/2/2026 3:46 PM, Luca Ceresoli wrote:
> Hello Damon,
>
> On Tue Mar 31, 2026 at 9:21 AM CEST, Damon Ding wrote:
> > On 3/31/2026 3:25 AM, Luca Ceresoli wrote:
> > > The meaning of this flag may not be obvious at first sight.
> > >
> > > Reviewed-by: Liu Ying <victor.liu@xxxxxxx>
> > > Tested-by: Martyn Welch <martyn.welch@xxxxxxxxxxxxx>
> > > Tested-by: Alexander Stein <alexander.stein@xxxxxxxxxxxxxxx> # TQMa8MPxL/MBa8MPxL
> > > Signed-off-by: Luca Ceresoli <luca.ceresoli@xxxxxxxxxxx>
>
> Thanks for looking at this series!
>
> > > @@ -126,6 +126,12 @@ struct dw_hdmi_phy_ops {
> > >    struct dw_hdmi_plat_data {
> > >    	struct regmap *regm;
> > >
> > > +	/*
> > > +	 * The HDMI output port number must be 1 if the port is described
> > > +	 * in the device tree. 0 if the device tree does not describe the
> > > +	 * next component (legacy mode, i.e. without
> > > +	 * DRM_BRIDGE_ATTACH_NO_CONNECTOR flag when attaching bridge).
> > > +	 */
> > >    	unsigned int output_port;
> > >
> > >    	unsigned long input_bus_encoding;
> >
> > Tested-by: Damon Ding <damon.ding@xxxxxxxxxxxxxx> (on rk3399)
>
> Uhm, I'm not sure what can be tested in a patch only adding a comment. Did
> you mean 'Reviewed-by' maybe?
>
> Also, I _think_ the best syntax for a comment would be using a '#', not
> parentheses, so that would be
>
> | Tested-by: Damon Ding <damon.ding@xxxxxxxxxxxxxx> # on rk3399
>
> This is the recommended syntax for the 'Cc: stable' lines [0], at
> least. Additionally b4 keeps comments with the '#' as those in [1], while
> is discards the ones in parentheses.
>
> [0] https://docs.kernel.org/process/stable-kernel-rules.html
> [1] https://lore.kernel.org/all/2948177.mvXUDI8C0e@steina-w/

Indeed, '#' is much better.

I think we still need to further discuss the various cases around 
DRM_BRIDGE_ATTACH_NO_CONNECTOR in [PATCH v2 06/10].

Best regards,
Damon