Re: [PATCH 3/4] perf arm_spe: Decode Arm N1 IMPDEF events

From: James Clark

Date: Thu Apr 02 2026 - 05:54:40 EST




On 02/04/2026 10:32 am, Leo Yan wrote:
On Wed, Apr 01, 2026 at 03:25:51PM +0100, James Clark wrote:

[...]

static int arm_spe_pkt_desc_event(const struct arm_spe_pkt *packet,
- char *buf, size_t buf_len)
+ char *buf, size_t buf_len, u64 midr)

Just wandering if we can add a "midr" field into struct arm_spe_pkt ?
Then we don't need to change many functions for populating midr.

The rest is good for me.

Thanks,
Leo

Yeah I can do that. I was worried they were stored in an array and it would be a waste of space, but they're not so it's ok.