Re: [PATCH 1/3] dt-bindings: timestamp: Add Tegra264 support
From: Krzysztof Kozlowski
Date: Thu Apr 02 2026 - 06:06:54 EST
On 02/04/2026 11:49, Jon Hunter wrote:
>
> On 02/04/2026 09:47, Krzysztof Kozlowski wrote:
>> On 02/04/2026 10:47, Krzysztof Kozlowski wrote:
>>> On Wed, Apr 01, 2026 at 09:38:29PM +0000, Suneel Garapati wrote:
>>>> reg:
>>>> maxItems: 1
>>>> @@ -112,6 +114,7 @@ allOf:
>>>> contains:
>>>> enum:
>>>> - nvidia,tegra234-gte-aon
>>>> + - nvidia,tegra264-gte-aon
>>>
>>> And why exactly the slices are variable here? Explain that in commit
>>> msg.
>>
>> s/Explain/Shortly describe/
>
> So this is not related to slices, but indicating the
> 'nvidia,gpio-controller' property is required for the AON controller.
> However, maybe your comment still applies and you want the commit
> message to be explicit that for the AON instance the
> 'nvidia,gpio-controller' is needed?
You have two devices there - AON and LIC - and variable properties. I
want answer why things are variable. HW is rarely variable. It is
opposite of variable - afixed.
Best regards,
Krzysztof