Re: [PATCH v4 0/2] hwmon: pmbus: Sony APS-379

[Guenter Roeck]

On 4/1/26 19:40, Chris Packham wrote:
> This series add support for the PMBus hwmon on the Sony
> APS-379 power supply module. There's some deviations from
> the PMBus specification that need to be dealt with.
>
> Chris Packham (2):
>    dt-bindings: trivial-devices: Add sony,aps-379
>    hwmon: pmbus: Add support for Sony APS-379
>
>   .../devicetree/bindings/trivial-devices.yaml  |   2 +
>   Documentation/hwmon/aps-379.rst               |  58 ++++++
>   Documentation/hwmon/index.rst                 |   1 +
>   drivers/hwmon/pmbus/Kconfig                   |   6 +
>   drivers/hwmon/pmbus/Makefile                  |   1 +
>   drivers/hwmon/pmbus/aps-379.c                 | 178 ++++++++++++++++++
>   6 files changed, 246 insertions(+)
>   create mode 100644 Documentation/hwmon/aps-379.rst
>   create mode 100644 drivers/hwmon/pmbus/aps-379.c

Sashiko still doesn't like it.

https://sashiko.dev/#/patchset/20260402024101.4136697-1-chris.packham%40alliedtelesis.co.nz

- Yes, "extracted while probing" is no longer accurate.
  Maybe add a comment explaining that the exponent is constant.
  Maybe even use a define ? That would make struct aps_379_data
  unnecessary.

- Rejecting virtual registers: Why indeed ? Is there a reason ?

Thanks,
Guenter