Re: [PATCH 6.6 000/175] 6.6.131-rc1 review

[Greg KH]

On Thu, Apr 02, 2026 at 01:27:12PM +0200, Miguel Ojeda wrote:
> On Tue, 31 Mar 2026 18:19:44 +0200 Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx> wrote:
> >
> > This is the start of the stable review cycle for the 6.6.131 release.
> > There are 175 patches in this series, all will be posted as a response
> > to this one.  If anyone has any issues with these being applied, please
> > let me know.
> >
> > Responses should be made by Thu, 02 Apr 2026 16:16:56 +0000.
> > Anything received after that time might be too late.
> 
> The pin-init change does not build:
> 
>     error[E0425]: cannot find value `__refcount_guard` in this scope
>         --> rust/kernel/init/macros.rs:1320:25
>          |
>     1320 |                   @guards([< __ $field _guard >], $($guards,)*),
>          |                           ^^^^^^^^^^^^^^^^^^^^^^ not found in this scope
>          |
>         ::: rust/kernel/sync/arc.rs:529:49
>          |
>     529  |           let inner = Box::try_init::<AllocError>(try_init!(ArcInner {
>          |  _________________________________________________-
>     530  | |             // SAFETY: There are no safety requirements for this FFI call.
>     531  | |             refcount: Opaque::new(unsafe { bindings::REFCOUNT_INIT(1) }),
>     532  | |             data <- init::uninit::<T, AllocError>(),
>     533  | |         }? AllocError))?;
>          | |______________________- in this macro invocation
>          |
>          = note: this error originates in the macro `$crate::__init_internal` which comes from the expansion of the macro `try_init` (in Nightly builds, run with -Z macro-backtrace for more info)
> 
> (among other errors)
> 
> I would suggest dropping these for now:
> 
>     0565326613fa ("rust: pin-init: internal: init: document load-bearing fact of field accessors")
>     66655aacfa42 ("rust: pin-init: add references to previously initialized fields")
> 
> Cc: Benno Lossin <lossin@xxxxxxxxxx>
> Cc: Gary Guo <gary@xxxxxxxxxxx>

Crap, I just did a realease.  Let me go revert these and do a new
release with that fixed, sorry about that, I guess my builds weren't
testing rust on older kernels, my fault :(

greg k-h