Re: [net-next,v3,04/13] net: renesas: rswitch: add register definitions for vlan support

[Paolo Abeni]

This is an AI-generated review of your patch. The human sending this
email has considered the AI review valid, or at least plausible.

For local reproduction steps see https://netdev-ai.bots.linux.dev/ai-local.html
---
net: renesas: rswitch: add register definitions for vlan support

This commit adds missing register and bit definitions for vlan support
in the Renesas R-Switch driver.

> diff --git a/drivers/net/ethernet/renesas/rswitch.h b/drivers/net/ethernet/renesas/rswitch.h
> index 340524d995ac..15d3fa48b0e3 100644
> --- a/drivers/net/ethernet/renesas/rswitch.h
> +++ b/drivers/net/ethernet/renesas/rswitch.h

[ ... ]

> @@ -847,6 +903,98 @@ enum rswitch_gwca_mode {
>  #define FWMACAGC_MACAGOG	BIT(28)
>  #define FWMACAGC_MACDESOG	BIT(29)
>
> +//FWMACTL0

[ ... ]

> +// FWVLANTEM
> +#define VLANTUEN		GENMASK(28, 16)
> +#define VLANTEN			GENAMSK(12, 0)
                                ^^^^^^^^

Is GENAMSK a typo? The correct macro is GENMASK, as used on the line
immediately above for VLANTUEN. GENAMSK is not defined in the kernel and
will cause compilation errors if VLANTEN is used.

> +
> +// FWVLANTS

[ ... ]