Re: [PATCH v8 3/4] platform/x86: int3472: Parameterize LED con_id in registration

From: Andy Shevchenko

Date: Thu Apr 02 2026 - 09:11:25 EST


On Wed, Apr 01, 2026 at 10:36:37PM +0200, Marco Nenciarini wrote:
> Add a con_id parameter to skl_int3472_register_led() to allow callers
> to specify both the LED name suffix and lookup con_id instead of
> hardcoding "privacy". This prepares for registering additional LED
> types with different names.
>
> While at it, rename the privacy LED's GPIO con_id from "privacy-led"
> to "privacy" in int3472_get_con_id_and_polarity() and pass it
> directly to skl_int3472_register_led(), reducing churn when adding
> new LED types.
>
> No functional change.

> Reviewed-by: Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx>
> Reviewed-by: Hans de Goede <johannes.goede@xxxxxxxxxxxxxxxx>
> Signed-off-by: Marco Nenciarini <mnencia@xxxxxxxx>
> ---
>
> Cc: Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx>
> Cc: Hans de Goede <johannes.goede@xxxxxxxxxxxxxxxx>

Just for the information, if you got a tag from a person from Cc list, no need
anymore to have a Cc entry, any official tag is also considered as "Cc to ...".
But it's quite minor, duplications are usually got resolved also by tools.

--
With Best Regards,
Andy Shevchenko