Re: [PATCH] staging: atomisp: fix alignment in function signature

From: Andy Shevchenko

Date: Thu Apr 02 2026 - 09:15:23 EST


On Thu, Apr 02, 2026 at 02:56:08PM +0200, Joshua Crofts wrote:
> On Thu, 2 Apr 2026 at 14:50, Andy Shevchenko
> <andriy.shevchenko@xxxxxxxxx> wrote:
> > First of all, missing period at the end.
> > Second, why? Does it fix anything?
> > Third, is this the only issue with the driver of a kind?
> >
> Hi, I was doing some checkpatch.pl work and got a few check errors.
> Wasn't sure if it's convention to group all check errors together or do each
> separately. Apologies for the misleading commit name, i'm aware it's cleanup
> and not a fix.

It is okay and good to group the fixes for the same driver of the same kind.
I don't believe it's the only single problem of this kind in this driver.
But you may double check and fix them all.


--
With Best Regards,
Andy Shevchenko