Re: [PATCH] x86/ptrace: Use savesegment() in get_segment_reg() instead of inline asm

[Uros Bizjak]

On Thu, Apr 2, 2026 at 2:48 PM Oleg Nesterov <oleg@xxxxxxxxxx> wrote:
>
> On 04/02, Uros Bizjak wrote:
> >
> > @@ -251,32 +251,31 @@ static u16 get_segment_reg(struct task_struct *task, unsigned long offset)
> >       /*
> >        * Returning the value truncates it to 16 bits.
> >        */
> > -     unsigned int seg;
> > +     unsigned int retval;
>
> LGTM, but perhaps it would be better to use "u16 retval" ? and remove the
> comment.

With the new definition of savesegment(), this is actually NOP from
the compiler PoV.

There is a corresponding x86_32 get_segment_reg() function that has
the same definition of retval, I can prepare a follow-up patch that
changes both.

Thanks,
Uros.