Re: [PATCH] misc: altera-stapl: Replace sprintf with hex_asc_lo for hex conversion

[Aravind]

Heya greg,

Thanks for the feedback.

I thought I had the hardware to test the change but it ain't the one.
So I am dropping the patch for now.

Appreciate the guidance.

Thanks,
Aravind


On Thu, Apr 2, 2026 at 7:53 PM Greg KH <gregkh@xxxxxxxxxxxxxxxxxxx> wrote:
>
> On Thu, Mar 26, 2026 at 01:32:57PM -0400, aravindanilraj0702@xxxxxxxxx wrote:
> > From: Aravind Anilraj <aravindanilraj0702@xxxxxxxxx>
> >
> > Replace sprintf() calls used to format single hex digits with direct
> > assignment using hex_asc_lo().This avoids unnecessary overhead
> > from using sprintf for single character output.
> >
> > No functional changes.
>
> Nah, this driver is so old, let's just leave it alone wherever possible,
> unless you have the hardware to actually test your changes?
>
> thanks,
>
> greg k-h