Re: [PATCH v2] ALSA: hda: Notify IEC958 Default PCM switch state changes

[Takashi Iwai]

On Thu, 02 Apr 2026 16:45:13 +0200,
Cássio Gabriel wrote:
> 
> --- a/sound/hda/common/hda_local.h
> +++ b/sound/hda/common/hda_local.h
> @@ -12,6 +12,8 @@
>  
>  #include <sound/pcm_drm_eld.h>
>  
> +struct snd_kcontrol;

No need for an extra declaration.

> +
>  /* We abuse kcontrol_new.subdev field to pass the NID corresponding to
>   * the given new control.  If id.subdev has a bit flag HDA_SUBDEV_NID_FLAG,
>   * snd_hda_ctl_add() takes the lower-bit subdev value as a valid NID.
> @@ -203,6 +205,7 @@ enum { HDA_DIG_NONE, HDA_DIG_EXCLUSIVE, HDA_DIG_ANALOG_DUP }; /* dig_out_used */
>  #define HDA_MAX_OUTS	5
>  
>  struct hda_multi_out {
> +	struct snd_kcontrol *share_spdif_kctl; /* cached shared SPDIF switch */

I'd put at the tail of the struct as it's rather an optional stuff.


thanks,

Takashi