Re: [PATCH v5 4/4] ARM: omap1: enable real software node lookup of GPIOs on Nokia 770

[Andy Shevchenko]

On Thu, Apr 02, 2026 at 04:15:05PM +0200, Bartosz Golaszewski wrote:
> Currently the board file for Nokia 770 creates dummy software nodes not
> attached in any way to the actual GPIO controller devices and uses the
> fact that GPIOLIB matching swnode's name to the GPIO chip's label during
> software node lookup. This behavior is wrong and we want to remove it.
> To that end, we need to first convert all existing users to creating
> actual fwnode links.
> 
> Create real software nodes for GPIO controllers on OMAP16xx and
> reference them from the software nodes in the nokia board file.

...

> +static const struct software_node omap16xx_gpio2_swnode = { };

No need to have {} for statically defined variables.
OTOH, if you want to have same style over exported and static,
perhaps it's okay.

> +static const struct software_node omap16xx_gpio3_swnode = { };

> +static const struct software_node omap16xx_gpio4_swnode = { };

-- 
With Best Regards,
Andy Shevchenko