Re: [RFC PATCH 1/5] pci_ids: Add Hygon Family 0x18 DF device IDs

[Mario Limonciello]

On 4/2/26 6:15 AM, Lin Wang wrote:
> [Some people who received this message don't often get email from wanglin@xxxxxxxxxxxxxx. Learn why this is important at https://aka.ms/LearnAboutSenderIdentification ]
>
> Add the PCI device IDs required to discover Hygon Family 0x18 Data Fabric
> functions.
>
> Hygon systems expose DF-related PCI functions using PCI_VENDOR_ID_HYGON.
> Some numeric device IDs are shared with AMD families but are qualified by
> PCI_VENDOR_ID_HYGON when used on Hygon systems.

I don't think this is a good idea to start precedent of using exact same 
define for Hygon and AMD because it might not always be true.

Could we instead have something like

#define PCI_DEVICE_ID_HYGON_17H_M30H_DF_F3 PCI_DEVICE_ID_AMD_17H_M30H_DF_F3

And then anywhere you're using it like you describe (such as how I see 
in patch 3) then you can use PCI_DEVICE_ID_HYGON_17H_M30H_DF_F3 instead.

> Signed-off-by: Lin Wang <wanglin@xxxxxxxxxxxxxx>
> ---
>   include/linux/pci_ids.h | 4 ++++
>   1 file changed, 4 insertions(+)
>
> diff --git a/include/linux/pci_ids.h b/include/linux/pci_ids.h
> index 406abf629be2..0b51773412be 100644
> --- a/include/linux/pci_ids.h
> +++ b/include/linux/pci_ids.h
> @@ -568,8 +568,10 @@
>   #define PCI_DEVICE_ID_AMD_16H_M30H_NB_F3 0x1583
>   #define PCI_DEVICE_ID_AMD_16H_M30H_NB_F4 0x1584
>   #define PCI_DEVICE_ID_AMD_17H_DF_F3    0x1463
> +#define PCI_DEVICE_ID_AMD_17H_DF_F4    0x1464
>   #define PCI_DEVICE_ID_AMD_17H_M10H_DF_F3 0x15eb
>   #define PCI_DEVICE_ID_AMD_17H_M30H_DF_F3 0x1493
> +#define PCI_DEVICE_ID_AMD_17H_M30H_DF_F4 0x1494
>   #define PCI_DEVICE_ID_AMD_17H_M40H_DF_F3 0x13f3
>   #define PCI_DEVICE_ID_AMD_17H_M60H_DF_F3 0x144b
>   #define PCI_DEVICE_ID_AMD_17H_M70H_DF_F3 0x1443
> @@ -2613,6 +2615,8 @@
>   #define PCI_VENDOR_ID_ROCKCHIP         0x1d87
>
>   #define PCI_VENDOR_ID_HYGON            0x1d94
> +#define PCI_DEVICE_ID_HYGON_18H_M05H_DF_F3     0x14b3
> +#define PCI_DEVICE_ID_HYGON_18H_M10H_DF_F3     0x14d3
>
>   #define PCI_VENDOR_ID_META             0x1d9b
>
> --
> 2.43.0