Re: [PATCH v2 0/3] perf metricgroup: Fix segmentation fault and refine logs

[Ian Rogers]

On Thu, Apr 2, 2026 at 9:04 AM Leo Yan <leo.yan@xxxxxxx> wrote:
>
> The first patch is to fix segmentation fault if there have syntax errors
> in metric groups.
>
> The last two patches are to refine logs to give users clear hints for
> failures.
>
> Signed-off-by: Leo Yan <leo.yan@xxxxxxx>

For the series:
Reviewed-by: Ian Rogers <irogers@xxxxxxxxxx>

Thanks,
Ian

> ---
> Changes in v2:
> - Added fix tags (James).
> - Added before and after logs (James).
> - Link to v1: https://lore.kernel.org/r/20260327-perf_fix_metrics_group-v1-1-49e4b8ee9a08@xxxxxxx
>
> ---
> Leo Yan (3):
>       perf expr: Return -EINVAL for syntax error in expr__find_ids()
>       perf expr: Add '\n' in literal parse errors
>       perf metricgroup: Refine error logs
>
>  tools/perf/util/expr.c        |  7 ++++---
>  tools/perf/util/metricgroup.c | 11 ++++++-----
>  2 files changed, 10 insertions(+), 8 deletions(-)
> ---
> base-commit: d9db9c8db56c3e378aa5c91637664f77ca5a6f72
> change-id: 20260327-perf_fix_metrics_group-4be55b236f96
>
> Best regards,
> --
> Leo Yan <leo.yan@xxxxxxx>
>