Re: [PATCh v3 05/14] ASoC: rsnd: Add audmacpp clock and reset support for RZ/G3E

[Kuninori Morimoto]

Hi John

Thank you for your patch

> RZ/G3E requires additional audmapp clock and reset lines for
> Audio DMA-PP operation.
> 
> Add global audmacpp clock/reset management in rsnd_dma_probe()
> using optional APIs to remain transparent to other platforms.
> 
> Signed-off-by: John Madieu <john.madieu.xa@xxxxxxxxxxxxxx>
> ---
(snip)
> --- a/sound/soc/renesas/rcar/rsnd.h
> +++ b/sound/soc/renesas/rcar/rsnd.h
> @@ -623,6 +623,13 @@ void rsnd_adg_clk_dbg_info(struct rsnd_priv *priv, struct seq_file *m);
>  struct rsnd_priv {
>  
>  	struct platform_device *pdev;
> +
> +	/*
> +	 * below value will be filled on rsnd_dma_probe()
> +	 */
> +	struct clk *audmapp_clk;
> +	struct reset_control *audmapp_rstc;

I think it is DMA specific.
I think we can move it to struct rsnd_dma, instead of in rsnd_priv ?

Thank you for your help !!

Best regards
---
Kuninori Morimoto