Re: [PATCh v3 12/14] ASoC: rsnd: Add rsnd_adg_mod_get() for PM support

[Kuninori Morimoto]

Hi John

> Add rsnd_adg_mod_get() to retrieve the ADG module handle.
> 
> This is preparation for system suspend/resume support, where the PM
> callbacks need to access the ADG module to manage its clock and reset
> state. Other modules (SSI, SRC, CTU, MIX, DVC) already have their
> getters exported.
> 
> Signed-off-by: John Madieu <john.madieu.xa@xxxxxxxxxxxxxx>
> ---

This is just a comment.
The reason why other modules has getting function is it is needed
on rsnd_parse_connect_xxx() which is called in __rsnd_dai_probe().

> @@ -618,6 +618,7 @@ int rsnd_adg_set_cmd_timsel_gen2(struct rsnd_mod *cmd_mod,
>  #define rsnd_adg_clk_disable(priv)	rsnd_adg_clk_control(priv, 0)
>  int rsnd_adg_clk_control(struct rsnd_priv *priv, int enable);
>  void rsnd_adg_clk_dbg_info(struct rsnd_priv *priv, struct seq_file *m);
> +struct rsnd_mod *rsnd_adg_mod_get(struct rsnd_priv *priv);

The user of rsnd_adg_mod_get() is only ADG, no need to add it on rsnd.h ?

Thank you for your help !!

Best regards
---
Kuninori Morimoto