Re: [PATCH v10 0/7] Add AMD ISP4 driver
From: Du, Bin
Date: Thu Apr 02 2026 - 23:17:40 EST
Hi Laurent and Sakari,
Just a gentle reminder regarding the review request below. When you have
a moment, I would appreciate it if you could take a look at this patch
series. Your feedback would be very helpful to ensure the changes align
with upstream expectations and maintainability.
Thank you very much for your time and support.
On 3/20/2026 10:01 PM, Mario Limonciello wrote:
>
>
> On 3/20/2026 5:26 AM, Du, Bin wrote:
>> Hi Laurent Pinchart and Sakari,
>>
>> Would you please review the updated version at your convenience? This
>> revision resolves all previously identified issues, incorporates
>> feedback from earlier iterations, includes numerous improvements, and
>> has been verified on Linux kernel 7.0. Your feedback would be greatly
>> appreciated.
>>
>>
>> On 3/20/2026 4:41 PM, Bin Du wrote:
>>> Hello,
>>>
>>> AMD ISP4 is the AMD image processing gen 4 which can be found in HP
>>> ZBook Ultra G1a 14 inch Mobile Workstation PC (Ryzen AI Max 300 Series)
>>> (https://ubuntu.com/certified/202411-36043)
>>> This patch series introduces the initial driver support for the AMD
>>> ISP4.
>>>
>>> Patch summary:
>>> - Powers up/off and initializes ISP HW
>>> - Configures and kicks off ISP FW
>>> - Interacts with APP using standard V4l2 interface by video node
>>> - Controls ISP HW and interacts with ISP FW to do image processing
>>> - Supports enum/set output image format and resolution
>>> - Supports queueing buffer from app and dequeuing ISP filled buffer
>>> to App
>>> - It is verified on qv4l2, cheese and qcam
>>> - It is verified on Linux kernel 7.0 together with following patches
>>> ACPI: video: Switch over to auxiliary bus type (https://
>>> lore.kernel.org/all/5986516.DvuYhMxLoT@rafael.j.wysocki/)
>>> drm/amdgpu: Fix ISP segfault issue in kernel v7.0 (https://
>>> lore.kernel.org/all/20260311174251.3121654-1-pratap.nirujogi@xxxxxxx/)
>>> ACPI: bus: Fix MFD child automatic modprobe issue (https://
>>> lore.kernel.org/all/20260318034842.1216536-1-pratap.nirujogi@xxxxxxx/)
>
> Just to make it extra clear to anyone following along on the sidelines
> there was a lot of feedback sent on v9 of problems on 7.0 that weren't
> rooted in this series itself but rather these other Linux kernel
> changes. They are all landing in subsystem 7.0-rc releases, and thus
> these other subsystems should be in good shape for when this series is
> eventually accepted for linux-next.
>
>>>
>>> AMD ISP4 Key features:
>>> - Processes bayer raw data from the connected sensor and output them
>>> to different YUV formats
>>> - Downscale input image to different output image resolution
>>> - Pipeline to do image processing on the input image including
>>> demosaic, denoise, 3A, etc.
>>>
>>> ----------
>>>
>>> Changes v9 -> v10:
>>>
>>> - Fixed build error on specific Clang/LLVM version (defining a macro
>>> as an array element is not allowed)
>>>
>>>
>>> Changes v8 -> v9:
>>>
>>> - Dropped wait_prepare/wait_finish vb2 callbacks (handled by
>>> framework via q->lock since v7.0-rc1).
>>> - Minor comment, typo and formatting fixes.
>>>
>>>
>>> Changes v7 -> v8:
>>>
>>> - Replaced ISP subdevice callbacks with direct function calls and
>>> deleted subdevice link validation functions and variables.
>>> - Removed unnecessary media pipeline operations, redundant media bus
>>> initialization, and omitted non-essential video format checks.
>>> - Applied code style improvements, including the 80-character line
>>> limit, standardizing macro variable naming from "v4l2_sdev" to "sd", and
>>> declaring loop variables inside for loops as unsigned where possible.
>>> - Added the ISP4FW_ prefix to all firmware interface definitions
>>> (such as command, image format, stream, buffer type), and corrected
>>> the typo "steam" to "stream".
>>> - Switched to common vb2 queue memory operations (vb2_vmalloc_memops)
>>> and updated Kconfig to add HAS_DMA dependency and VIDEOBUF2_VMALLOC
>>> selection.
>>> - Changed the order of header includes in several files, eliminated
>>> unused header inclusions, and reviewed grammar and spelling in comments.
>>> - Updated Kconfig and Makefile to change module names for ISP4, and
>>> modified the debugfs directory from amd_isp to amd_isp4.
>>> - Removed deprecated v4l2_pipeline_pm_put() and
>>> v4l2_pipeline_pm_get() calls, and replaced obsolete s_power() with
>>> runtime PM for power management.
>>>
>>>
>>> Changes v6 -> v7:
>>>
>>> - Added missed blank line after some if statements.
>>> - Changed the pm_runtime_disable() order in isp4_capture_remove() to
>>> align with initialization.
>>> - Reset buf_sent_cnt and start_stream_cmd_sent on stream stop.
>>> - Removed duplicate buf_sent_cnt and start_stream_cmd_sent reset in
>>> isp4sd_pwron_and_init().
>>> - Combined isp4sd_reset_stream_info() and isp4sd_reset_camera_info()
>>> into isp4sd_uninit_stream() to eliminate redundant stream info reset.
>>> - Removed always-false status check in isp4sd_uninit_stream().
>>> - Minor style improvements.
>>>
>>>
>>> Changes v5 -> v6:
>>>
>>> - Lowered FW mempool buffer size from 200M to 100M (actual usage).
>>> - Added an irq_enabled member to the ISP subdev for proper IRQ
>>> disable handling in both normal and error cases.
>>> - Removed unnecessary .owner assignment from isp4_capture_drv definition
>>> - Updated IRQ handling to enable and disable interrupts via the ISP
>>> register for improved performance.
>>> - Revised ring buffer management in isp4if_f2h_resp(), addressing
>>> safety checks to ensure the read pointer is validated before memcpy
>>> operations, reducing the risk of out-of-bounds access. The ring
>>> buffer logic was also streamlined significantly.
>>> - Modified ring buffer handling in isp4if_is_cmdq_rb_full(),
>>> correcting an off-by-one error in safety checks that previously
>>> allowed rd_ptr to equal wr_ptr when the buffer was full.
>>> - Refactored ring buffer handling in isp4if_insert_isp_fw_cmd(),
>>> simplifying overall logic.
>>> - Resolved a regression from v4 to v5 where isp4if_dequeue_buffer()
>>> did not protect list_del with bufq_lock.
>>> - Addressed a subtle use-after-free issue that could occur if a
>>> timeout on a synchronous command coincided with completion.
>>> - Added missing pm_runtime_disable() calls to isp4_capture_remove()
>>> and to the error path in isp4_capture_probe().
>>> - Removed stray semicolons following closing curly braces.
>>> - Improved and clarified macro definitions in isp4_interface.h.
>>> - Eliminated unnecessary (u8 *) casts.
>>> - Added missing memset for firmware command structures in
>>> isp4sd_stop_stream().
>>> - Excluded streams 2 and 3 from ISP4IF_FW_RESP_RB_IRQ_EN_MASK,
>>> preventing their activation in the interrupt enable register.
>>> - Enhanced error handling to clean up kthreads in the event of
>>> startup failure.
>>> - Corrected a race condition during kthread creation where waitqueue
>>> head initialization could be delayed, as it was performed by the
>>> kthread itself.
>>> - Removed status checks in isp4sd_pwroff_and_deinit() that were
>>> always false.
>>> - Ensured isp4sd_init_stream() is only invoked once per stream start
>>> and reordered corresponding status checks in isp4sd_start_stream().
>>> - Improved error handling in isp4sd_start_stream() to propagate
>>> errors from failed functions.
>>> - Relocated debugging messages in isp4sd_stop_stream() to execute
>>> under lock protection due to access to output_info->start_status.
>>> - Eliminated redundant GET_REG_BASE() macros.
>>> - Removed isp4sd_is_stream_running() function.
>>> - Corrected error message in isp4sd_init_stream() caused by copy/paste.
>>> - Refined struct isp4_interface to remove firmware ring buffer
>>> configurations.
>>> - Removed obsolete isp4sd_is_stream_running function.
>>> - Removed pdev member from struct isp4_device, as it is unnecessary.
>>> - Fixed typo in 'isp_mmip' parameter name within isp4if_init().
>>> - Removed gap in struct isp4_subdev definition.
>>> - Performed extensive dead code removal and minor style improvements
>>> throughout the codebase.
>>>
>>>
>>> Changes v4 -> v5:
>>>
>>> - Transitioned VIDEOBUF2_V4L2 from 'depends' to 'select' within Kconfig.
>>> - Standardized object file naming conventions in the Makefile and
>>> sorted entries alphabetically.
>>> - Removed the unused macro definition to_isp4_device.
>>> - Eliminated unused members mem_domain and mem_align from struct
>>> isp4if_gpu_mem_info.
>>> - Deleted unused fields mc_addr and gpu_pkg from struct
>>> isp4if_cmd_element.
>>> - Removed obsolete pltf_data, i2c_nb, and notifier elements from
>>> struct isp4_device.
>>> - Updated platform_get_irq failure handling to return its actual
>>> result rather than -ENODEV.
>>> - Refined inclusion of header files for clarity and efficiency.
>>> - Appended comments following #endif statements in header files.
>>> - Improved implementation of isp4if_gpu_mem_free and
>>> isp4if_dealloc_fw_gpumem.
>>> - Removed isp4if_append_cmd_2_cmdq and revised isp4if_send_fw_cmd
>>> accordingly.
>>> - Enhanced isp4if_clear_cmdq and isp4if_clear_bufq by eliminating
>>> unnecessary list_del operations.
>>> - Adopted completion mechanism instead of wait queue and condition
>>> for command completion notifications.
>>> - Employed memset to ensure proper zeroing of padding bits in
>>> structures shared between ISP driver and firmware.
>>> - Streamlined IRQs, reducing total from four to two, retaining only
>>> essential ones.
>>> - Optimized IRQ handler logic using a while loop for greater efficiency.
>>> - Introduced dynamic IRQ enable/disable functionality based on camera
>>> status (open/close).
>>> - Applied distinct identifiers to differentiate multiple threads and
>>> IRQs.
>>> - Removed unnecessary initialization of local variables.
>>> - Refined camera start/stop workflow to mitigate potential
>>> synchronization concerns.
>>> - Replaced all remaining mutex with guard mutex.
>>> - Enhanced command and buffer queue performance by substituting
>>> mutexes with spinlocks.
>>> - Removed redundant isp4sd_init_meta_buf function and its references.
>>> - Limited firmware logging activities to the stream1 thread.
>>> - Relocated v4l2_device_unregister_subdev() and
>>> media_entity_cleanup() calls from isp4_capture_remove to isp4sd_deinit.
>>> - Resolved media device registration sequence issues.
>>> - Modified stream processing thread behavior to await IRQ without a
>>> timeout.
>>> - Addressed cleanup procedures in video device initialization and
>>> deinitialization routines.
>>> - Corrected typos and made other cosmetic improvements.
>>>
>>>
>>> Changes v3 -> v4:
>>>
>>> - Replace one mutex with guard mutex.
>>> - Remove unnecessary bus_info initialization of v4l2_capability.
>>> - Drop V4L2_CAP_IO_MC from capabilities of v4l2_capability.
>>> - Modify document with better SOC description.
>>> - Fix Test x86 failure in Media CI test https://linux-
>>> media.pages.freedesktop.org/-/users/patchwork/-/jobs/83470456/
>>> artifacts/report.htm
>>> - Modify some commit messages by describing changes in imperative mood.
>>> - Add media-ctl output in cover letter.
>>> - Create separated dedicated amdgpu patch to add declaration
>>> MODULE_FIRMWARE("amdgpu/isp_4_1_1.bin");
>>> - Fix typo errors and other cosmetic issues.
>>> - Add DRM_AMD_ISP dependency in Kconfig.
>>>
>>>
>>> Changes v2 -> v3:
>>>
>>> - All the dependent patches in other modules (drm/amd/amdgpu,
>>> platform/x86, pinctrl/amd) merged on upstream mainline kernel
>>> (https://github.com/torvalds/linux) v6.17.
>>> - Removed usage of amdgpu structs in ISP driver. Added helper
>>> functions in amdgpu accepting opaque params from ISP driver to
>>> allocate and release ISP GART buffers.
>>> - Moved sensor and MIPI phy control entirely into ISP FW instead of
>>> the previous hybrid approach controlling sensor from both FW and x86
>>> (sensor driver).
>>> - Removed phy configuration and sensor binding as x86 (sensor driver)
>>> had relinquished the sensor control for ISP FW. With this approach
>>> the driver will be exposed as web camera like interface.
>>> - New FW with built-in sensor driver is submitted on upstream linux-
>>> firmware repo (https://gitlab.com/kernel-firmware/linux-firmware/).
>>> - Please note the new FW submitted is not directly compatible with
>>> OEM Kernel ISP4.0 (https://github.com/amd/Linux_ISP_Kernel/tree/4.0)
>>> and the previous ISP V2 patch series.
>>> - If intend to use the new FW, please rebuild OEM ISP4.0 Kernel with
>>> CONFIG_VIDEO_OV05C10=N and CONFIG_PINCTRL_AMDISP=Y.
>>> - Included critical fixes from Sultan Alsawaf branch (https://
>>> github.com/kerneltoast/kernel_x86_laptop.git) related to managing
>>> lifetime of isp buffers.
>>> media: amd: isp4: Add missing refcount tracking to mmap memop
>>> media: amd: isp4: Don't put or unmap the dmabuf when detaching
>>> media: amd: isp4: Don't increment refcount when dmabuf export
>>> fails
>>> media: amd: isp4: Fix possible use-after-free in
>>> isp4vid_vb2_put()
>>> media: amd: isp4: Always export a new dmabuf from get_dmabuf
>>> memop
>>> media: amd: isp4: Fix implicit dmabuf lifetime tracking
>>> media: amd: isp4: Fix possible use-after-free when putting
>>> implicit dmabuf
>>> media: amd: isp4: Simplify isp4vid_get_dmabuf() arguments
>>> media: amd: isp4: Move up buf->vaddr check in
>>> isp4vid_get_dmabuf()
>>> media: amd: isp4: Remove unused userptr memops
>>> media: amd: isp4: Add missing cleanup on error in
>>> isp4vid_vb2_alloc()
>>> media: amd: isp4: Release queued buffers on error in
>>> start_streaming
>>> - Addressed all code related upstream comments
>>> - Fix typo errors and other cosmetic issues.
>>>
>>>
>>> Changes v1 -> v2:
>>>
>>> - Fix media CI test errors and valid warnings
>>> - Reduce patch number in the series from 9 to 8 by merging
>>> MAINTAINERS adding patch to the first patch
>>> - In patch 5
>>> - do modification to use remote endpoint instead of local endpoint
>>> - use link frequency and port number as start phy parameter
>>> instead of extra added phy-id and phy-bit-rate property of endpoint
>>>
>>> ----------
>>>
>>> It passes v4l2 compliance test, the test reports for:
>>>
>>> (a) amd_isp_capture device /dev/video0
>>>
>>> Compliance test for amd_isp_capture device /dev/video0:
>>> -------------------------------------------------------
>>>
>>> atg@atg-HP-PV:~/bin$ ./v4l2-compliance -d /dev/video0
>>> v4l2-compliance 1.29.0-5348, 64 bits, 64-bit time_t
>>> v4l2-compliance SHA: 75e3f0e2c2cb 2025-03-17 18:12:17
>>>
>>> Compliance test for amd_isp_capture device /dev/video0:
>>>
>>> Driver Info:
>>> Driver name : amd_isp_capture
>>> Card type : amd_isp_capture
>>> Bus info : platform:amd_isp_capture
>>> Driver version : 6.14.0
>>> Capabilities : 0xa4200001
>>> Video Capture
>>> I/O MC
>>> Streaming
>>> Extended Pix Format
>>> Device Capabilities
>>> Device Caps : 0x24200001
>>> Video Capture
>>> I/O MC
>>> Streaming
>>> Extended Pix Format
>>> Media Driver Info:
>>> Driver name : amd_isp_capture
>>> Model : amd_isp41_mdev
>>> Serial :
>>> Bus info : platform:amd_isp_capture
>>> Media version : 6.14.0
>>> Hardware revision: 0x00000000 (0)
>>> Driver version : 6.14.0
>>> Interface Info:
>>> ID : 0x03000005
>>> Type : V4L Video
>>> Entity Info:
>>> ID : 0x00000003 (3)
>>> Name : Preview
>>> Function : V4L2 I/O
>>> Pad 0x01000004 : 0: Sink
>>> Link 0x02000007: from remote pad 0x1000002 of entity 'amd
>>> isp4' (Image Signal Processor): Data, Enabled, Immutable
>>>
>>> Required ioctls:
>>> test MC information (see 'Media Driver Info' above): OK
>>> test VIDIOC_QUERYCAP: OK
>>> test invalid ioctls: OK
>>>
>>> Allow for multiple opens:
>>> test second /dev/video0 open: OK
>>> test VIDIOC_QUERYCAP: OK
>>> test VIDIOC_G/S_PRIORITY: OK
>>> test for unlimited opens: OK
>>>
>>> Debug ioctls:
>>> test VIDIOC_DBG_G/S_REGISTER: OK (Not Supported)
>>> test VIDIOC_LOG_STATUS: OK (Not Supported)
>>>
>>> Input ioctls:
>>> test VIDIOC_G/S_TUNER/ENUM_FREQ_BANDS: OK (Not Supported)
>>> test VIDIOC_G/S_FREQUENCY: OK (Not Supported)
>>> test VIDIOC_S_HW_FREQ_SEEK: OK (Not Supported)
>>> test VIDIOC_ENUMAUDIO: OK (Not Supported)
>>> test VIDIOC_G/S/ENUMINPUT: OK
>>> test VIDIOC_G/S_AUDIO: OK (Not Supported)
>>> Inputs: 1 Audio Inputs: 0 Tuners: 0
>>>
>>> Output ioctls:
>>> test VIDIOC_G/S_MODULATOR: OK (Not Supported)
>>> test VIDIOC_G/S_FREQUENCY: OK (Not Supported)
>>> test VIDIOC_ENUMAUDOUT: OK (Not Supported)
>>> test VIDIOC_G/S/ENUMOUTPUT: OK (Not Supported)
>>> test VIDIOC_G/S_AUDOUT: OK (Not Supported)
>>> Outputs: 0 Audio Outputs: 0 Modulators: 0
>>>
>>> Input/Output configuration ioctls:
>>> test VIDIOC_ENUM/G/S/QUERY_STD: OK (Not Supported)
>>> test VIDIOC_ENUM/G/S/QUERY_DV_TIMINGS: OK (Not Supported)
>>> test VIDIOC_DV_TIMINGS_CAP: OK (Not Supported)
>>> test VIDIOC_G/S_EDID: OK (Not Supported)
>>>
>>> Control ioctls (Input 0):
>>> test VIDIOC_QUERY_EXT_CTRL/QUERYMENU: OK (Not Supported)
>>> test VIDIOC_QUERYCTRL: OK (Not Supported)
>>> test VIDIOC_G/S_CTRL: OK (Not Supported)
>>> test VIDIOC_G/S/TRY_EXT_CTRLS: OK (Not Supported)
>>> test VIDIOC_(UN)SUBSCRIBE_EVENT/DQEVENT: OK (Not Supported)
>>> test VIDIOC_G/S_JPEGCOMP: OK (Not Supported)
>>> Standard Controls: 0 Private Controls: 0
>>>
>>> Format ioctls (Input 0):
>>> test VIDIOC_ENUM_FMT/FRAMESIZES/FRAMEINTERVALS: OK
>>> test VIDIOC_G/S_PARM: OK
>>> test VIDIOC_G_FBUF: OK (Not Supported)
>>> test VIDIOC_G_FMT: OK
>>> test VIDIOC_TRY_FMT: OK
>>> test VIDIOC_S_FMT: OK
>>> test VIDIOC_G_SLICED_VBI_CAP: OK (Not Supported)
>>> test Cropping: OK (Not Supported)
>>> test Composing: OK (Not Supported)
>>> test Scaling: OK (Not Supported)
>>>
>>> Codec ioctls (Input 0):
>>> test VIDIOC_(TRY_)ENCODER_CMD: OK (Not Supported)
>>> test VIDIOC_G_ENC_INDEX: OK (Not Supported)
>>> test VIDIOC_(TRY_)DECODER_CMD: OK (Not Supported)
>>>
>>> Buffer ioctls (Input 0):
>>> test VIDIOC_REQBUFS/CREATE_BUFS/QUERYBUF: OK
>>> test CREATE_BUFS maximum buffers: OK
>>> test VIDIOC_REMOVE_BUFS: OK
>>> test VIDIOC_EXPBUF: OK
>>> test Requests: OK (Not Supported)
>>> test blocking wait: OK
>>>
>>> Total for amd_isp_capture device /dev/video0: 49, Succeeded: 49,
>>> Failed: 0, Warnings: 0
>>>
>>> The media-ctl output of media device /dev/media0:
>>> -------------------------------------------------------
>>>
>>> atg@atg-HP-PV:~$ media-ctl -p -d /dev/media0
>>> Media controller API version 6.17.0
>>>
>>> Media device information
>>> ------------------------
>>> driver amd_isp_capture
>>> model amd_isp41_mdev
>>> serial
>>> bus info platform:amd_isp_capture
>>> hw revision 0x0
>>> driver version 6.17.0
>>>
>>> Device topology
>>> - entity 1: amd isp4 (1 pad, 1 link, 0 routes)
>>> type V4L2 subdev subtype Unknown flags 0
>>> pad0: Source
>>> -> "Preview":0 [ENABLED,IMMUTABLE]
>>>
>>> - entity 3: Preview (1 pad, 1 link)
>>> type Node subtype V4L flags 0
>>> device node name /dev/video0
>>> pad0: Sink
>>> <- "amd isp4":0 [ENABLED,IMMUTABLE]
>>>
>>> Please review and provide feedback.
>>>
>>> Many thanks,
>>>
>>> Bin Du (7):
>>> media: platform: amd: Introduce amd isp4 capture driver
>>> media: platform: amd: low level support for isp4 firmware
>>> media: platform: amd: Add isp4 fw and hw interface
>>> media: platform: amd: isp4 subdev and firmware loading handling added
>>> media: platform: amd: isp4 video node and buffers handling added
>>> media: platform: amd: isp4 debug fs logging and more descriptive
>>> errors
>>> Documentation: add documentation of AMD isp 4 driver
>>>
>>> Documentation/admin-guide/media/amdisp4-1.rst | 63 +
>>> Documentation/admin-guide/media/amdisp4.dot | 6 +
>>> .../admin-guide/media/v4l-drivers.rst | 1 +
>>> MAINTAINERS | 25 +
>>> drivers/media/platform/Kconfig | 1 +
>>> drivers/media/platform/Makefile | 1 +
>>> drivers/media/platform/amd/Kconfig | 3 +
>>> drivers/media/platform/amd/Makefile | 3 +
>>> drivers/media/platform/amd/isp4/Kconfig | 15 +
>>> drivers/media/platform/amd/isp4/Makefile | 10 +
>>> drivers/media/platform/amd/isp4/isp4.c | 240 ++++
>>> drivers/media/platform/amd/isp4/isp4.h | 20 +
>>> drivers/media/platform/amd/isp4/isp4_debug.c | 271 +++++
>>> drivers/media/platform/amd/isp4/isp4_debug.h | 41 +
>>> .../platform/amd/isp4/isp4_fw_cmd_resp.h | 318 +++++
>>> drivers/media/platform/amd/isp4/isp4_hw_reg.h | 124 ++
>>> .../media/platform/amd/isp4/isp4_interface.c | 832 +++++++++++++
>>> .../media/platform/amd/isp4/isp4_interface.h | 144 +++
>>> drivers/media/platform/amd/isp4/isp4_subdev.c | 1047 +++++++++++++++++
>>> drivers/media/platform/amd/isp4/isp4_subdev.h | 127 ++
>>> drivers/media/platform/amd/isp4/isp4_video.c | 797 +++++++++++++
>>> drivers/media/platform/amd/isp4/isp4_video.h | 57 +
>>> 22 files changed, 4146 insertions(+)
>>> create mode 100644 Documentation/admin-guide/media/amdisp4-1.rst
>>> create mode 100644 Documentation/admin-guide/media/amdisp4.dot
>>> create mode 100644 drivers/media/platform/amd/Kconfig
>>> create mode 100644 drivers/media/platform/amd/Makefile
>>> create mode 100644 drivers/media/platform/amd/isp4/Kconfig
>>> create mode 100644 drivers/media/platform/amd/isp4/Makefile
>>> create mode 100644 drivers/media/platform/amd/isp4/isp4.c
>>> create mode 100644 drivers/media/platform/amd/isp4/isp4.h
>>> create mode 100644 drivers/media/platform/amd/isp4/isp4_debug.c
>>> create mode 100644 drivers/media/platform/amd/isp4/isp4_debug.h
>>> create mode 100644 drivers/media/platform/amd/isp4/isp4_fw_cmd_resp.h
>>> create mode 100644 drivers/media/platform/amd/isp4/isp4_hw_reg.h
>>> create mode 100644 drivers/media/platform/amd/isp4/isp4_interface.c
>>> create mode 100644 drivers/media/platform/amd/isp4/isp4_interface.h
>>> create mode 100644 drivers/media/platform/amd/isp4/isp4_subdev.c
>>> create mode 100644 drivers/media/platform/amd/isp4/isp4_subdev.h
>>> create mode 100644 drivers/media/platform/amd/isp4/isp4_video.c
>>> create mode 100644 drivers/media/platform/amd/isp4/isp4_video.h
>>>
>>
>
--
Regards,
Bin