Re: [PATCH] clockevents: Prevent timer interrupt starvation

[Calvin Owens]

On Thursday 04/02 at 19:07 +0200, Thomas Gleixner wrote:
> Calvin reported an odd NMI watchdog lockup which claims that the CPU locked
> up in user space. He provided a reproducer, which set's up a timerfd based
> timer and then rearms it in a loop with an absolute expiry time of 1ns.
> 
> As the expiry time is in the past, the timer ends up as the first expiring
> timer in the per CPU hrtimer base and the clockevent device is programmed
> with the minimum delta value. If the machine is fast enough, this ends up
> in a endless loop of programming the delta value to the minimum value
> defined by the clock event device, before the timer interrupt can fire,
> which starves the interrupt and consequently triggers the lockup detector
> because the hrtimer callback of the lockup mechanism is never invoked.
> 
> As a first step to prevent this, avoid reprogramming the clock event device
> when:
>      - a forced minimum delta event is pending
>      - the new expiry delta is less then or equal to the minimum delta
> 
> Thanks to Calvin for providing the reproducer and to Borislav for testing
> and providing data from his Zen5 machine.
> 
> The problem is not limited to Zen5, but depending on the underlying
> clock event device (e.g. TSC deadline timer on Intel) and the CPU speed
> not necessarily observable.
> 
> This change serves only as the last resort and further changes will be made
> to prevent this scenario earlier in the call chain.
> 
> Reported-by: Calvin Owens <calvin@xxxxxxxxxx>
> Signed-off-by: Thomas Gleixner <tglx@xxxxxxxxxx>
> ---
> P.S: I'm working on the other changes, but wanted to get this out ASAP
>      for testing.

Unfortunately the AMD boxes won't boot with this: one gives me no
video console output, the other gets to userspace but hangs trying to
mount the rootfs and then prints hard lockup traces with idle stacks.

Sorry not to have more info yet, I'll have time tomorrow to sit down and
get more data for you. If there's anything specific that you'd like me
grab just let me know.

Thanks,
Calvin

> ---
>  include/linux/clockchips.h |    2 ++
>  kernel/time/clockevents.c  |   37 +++++++++++++++++++++++--------------
>  2 files changed, 25 insertions(+), 14 deletions(-)
> 
> --- a/include/linux/clockchips.h
> +++ b/include/linux/clockchips.h
> @@ -80,6 +80,7 @@ enum clock_event_state {
>   * @shift:		nanoseconds to cycles divisor (power of two)
>   * @state_use_accessors:current state of the device, assigned by the core code
>   * @features:		features
> + * @next_event_forced:	True if the last programming was a forced event
>   * @retries:		number of forced programming retries
>   * @set_state_periodic:	switch state to periodic
>   * @set_state_oneshot:	switch state to oneshot
> @@ -108,6 +109,7 @@ struct clock_event_device {
>  	u32			shift;
>  	enum clock_event_state	state_use_accessors;
>  	unsigned int		features;
> +	unsigned int		next_event_forced;
>  	unsigned long		retries;
>  
>  	int			(*set_state_periodic)(struct clock_event_device *);
> --- a/kernel/time/clockevents.c
> +++ b/kernel/time/clockevents.c
> @@ -172,6 +172,7 @@ void clockevents_shutdown(struct clock_e
>  {
>  	clockevents_switch_state(dev, CLOCK_EVT_STATE_SHUTDOWN);
>  	dev->next_event = KTIME_MAX;
> +	dev->next_event_forced = 0;
>  }
>  
>  /**
> @@ -224,13 +225,7 @@ static int clockevents_increase_min_delt
>  	return 0;
>  }
>  
> -/**
> - * clockevents_program_min_delta - Set clock event device to the minimum delay.
> - * @dev:	device to program
> - *
> - * Returns 0 on success, -ETIME when the retry loop failed.
> - */
> -static int clockevents_program_min_delta(struct clock_event_device *dev)
> +static int __clockevents_program_min_delta(struct clock_event_device *dev)
>  {
>  	unsigned long long clc;
>  	int64_t delta;
> @@ -263,13 +258,7 @@ static int clockevents_program_min_delta
>  
>  #else  /* CONFIG_GENERIC_CLOCKEVENTS_MIN_ADJUST */
>  
> -/**
> - * clockevents_program_min_delta - Set clock event device to the minimum delay.
> - * @dev:	device to program
> - *
> - * Returns 0 on success, -ETIME when the retry loop failed.
> - */
> -static int clockevents_program_min_delta(struct clock_event_device *dev)
> +static int __clockevents_program_min_delta(struct clock_event_device *dev)
>  {
>  	unsigned long long clc;
>  	int64_t delta = 0;
> @@ -293,6 +282,21 @@ static int clockevents_program_min_delta
>  #endif /* CONFIG_GENERIC_CLOCKEVENTS_MIN_ADJUST */
>  
>  /**
> + * clockevents_program_min_delta - Set clock event device to the minimum delay.
> + * @dev:	device to program
> + *
> + * Returns 0 on success, -ETIME when the retry loop failed.
> + */
> +static int clockevents_program_min_delta(struct clock_event_device *dev)
> +{
> +	if (dev->next_event_forced)
> +		return 0;
> +
> +	dev->next_event_forced = 1;
> +	return __clockevents_program_min_delta(dev);
> +}
> +
> +/**
>   * clockevents_program_event - Reprogram the clock event device.
>   * @dev:	device to program
>   * @expires:	absolute expiry time (monotonic clock)
> @@ -324,6 +328,11 @@ int clockevents_program_event(struct clo
>  		return dev->set_next_ktime(expires, dev);
>  
>  	delta = ktime_to_ns(ktime_sub(expires, ktime_get()));
> +
> +	/* Don't reprogram when a forced event is pending */
> +	if (dev->next_event_forced && delta <= (int64_t)dev->min_delta_ns)
> +		return 0;
> +
>  	if (delta <= 0)
>  		return force ? clockevents_program_min_delta(dev) : -ETIME;
>