Re: [Openipmi-developer] [PATCH 1/5] ipmi: ssif_bmc: cancel response timer on remove

From: Quan Nguyen

Date: Fri Apr 03 2026 - 03:26:58 EST




On 2/4/26 22:42, Corey Minyard wrote:
On Thu, Apr 02, 2026 at 07:04:31PM +0800, Jian Zhang via Openipmi-developer wrote:
The response timer can stay armed across device teardown. If it fires after
remove, the callback dereferences the SSIF context and the i2c client after
teardown has started.

Cancel the timer in remove so the callback cannot run after the device is
unregistered.

This whole series looks good to me, and I have added it to my next tree.
I'd like to hear from Quan, though.


The whole series looks good to me too. Just a little concern on the 3/5 part as we have not yet encountered.

Thanks for the patches
-- Quan