Re: [PATCh v3 09/14] ASoC: rsnd: Add ADG reset support for RZ/G3E

[Geert Uytterhoeven]

Hi John,

On Thu, 2 Apr 2026 at 18:53, John Madieu <john.madieu.xa@xxxxxxxxxxxxxx> wrote:
> RZ/G3E requires the ADG reset line to be deasserted for the audio
> subsystem to operate. The ADG module clock is already managed via
> rsnd_adg_clk_enable/disable() through adg->adg, so no additional
> clock handling is needed.
>
> Add support for the optional "adg" reset control on Renesas RZ/G3E SoC.
>
> Signed-off-by: John Madieu <john.madieu.xa@xxxxxxxxxxxxxx>

Thanks for your patch!

> --- a/sound/soc/renesas/rcar/adg.c
> +++ b/sound/soc/renesas/rcar/adg.c
> @@ -771,6 +771,7 @@ void rsnd_adg_clk_dbg_info(struct rsnd_priv *priv, struct seq_file *m)
>
>  int rsnd_adg_probe(struct rsnd_priv *priv)
>  {
> +       struct reset_control *rstc;
>         struct rsnd_adg *adg;
>         struct device *dev = rsnd_priv_to_dev(priv);
>         int ret;
> @@ -779,8 +780,13 @@ int rsnd_adg_probe(struct rsnd_priv *priv)
>         if (!adg)
>                 return -ENOMEM;
>
> +       rstc = devm_reset_control_get_optional_exclusive(dev, "adg");
> +       if (IS_ERR(rstc))
> +               return dev_err_probe(dev, PTR_ERR(rstc),
> +                                    "failed to get adg reset\n");

Given this file already uses lines longer than 80 characters, the
above statement would fit on a single line.

> +
>         ret = rsnd_mod_init(priv, &adg->mod, &adg_ops,
> -                     NULL, NULL, 0, 0);
> +                     NULL, rstc, 0, 0);

This one fits for sure.

>         if (ret)
>                 return ret;
>

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds