Re: [PATCH v5 23/27] clk: mediatek: Add MT8196 disp-ao clock support

[Jason-JH Lin (林睿祥)]

[snip]

> > > +static const struct of_device_id of_match_clk_mt8196_vdisp_ao[]
> > > = {
> > > +	{ .compatible = "mediatek,mt8196-vdisp-ao", .data =
> > > &mm_v_mcd },
> > 
> > Hi Laura,
> > 
> > We are going to send mtk-mmsys driver for MT8196 recently, but we
> > found
> > the compatible name is used here.
> > 
> > As your commit message, vdisp-ao is integrated with the mtk-mmsys
> > driver, which registers the vdisp-ao clock driver via 
> > platform_device_register_data().
> > 
> > Shouldn't this compatible name belong to mmsys driver for MT8196?
> > 
> 
> That's right, my fault for missing that! Thanks for the heads up.
> 
> I'm aware Angelo is currently restructuring mediatek-drm (including 
> mmsys and mutex), and that might affect the way vdisp-ao is loaded
> too. 
> So I'm not sure whether it makes sense to send a patch to fix this 
> right away.

OK, we'll try to contact Angelo from other places.
Thanks for your confirmation!

Regards,
Jason-JH.Lin

> 
> Best,
> 
> Laura
>