Re: [PATCh v3 07/14] ASoC: rsnd: ssui: Add RZ/G3E SSIU BUSIF support

[Mark Brown]

On Fri, Apr 03, 2026 at 01:18:07AM +0000, Kuninori Morimoto wrote:

> > > @@ -160,7 +161,8 @@ static int rsnd_ssiu_init(struct rsnd_mod *mod,
> > >  	/*
> > >  	 * SSI_MODE0
> > >  	 */
> > > -	rsnd_mod_bset(mod, SSI_MODE0, (1 << id), !use_busif << id);
> > > +	if (!rsnd_is_rzg3e(priv))
> > > +		rsnd_mod_bset(mod, SSI_MODE0, (1 << id), !use_busif << id);

> > Perhaps should be a capability flag like the changelog said?

> Have or not have registers are depending on the each SoC, and (probably)
> there's no regularity to it.
> And SoC special handling is needed not only for the register settings.

> There is no clear rule on this driver for now.
> Handling it by flag is one the idea, but rsnd_is_xxx() is enough for now.
> Because it is easy to find SoC specific handling part by "grep rsnd_is_"

To be clear I don't mind either way, it's just that the changelog and
the change don't line up.

Attachment: signature.asc
Description: PGP signature