Re: [PATCH 2/2] rust: macros: simplify `format!` arguments

[Sami Tolvanen]

Hi Miguel,

On Thu, Apr 2, 2026 at 9:53 PM Miguel Ojeda
<miguel.ojeda.sandonis@xxxxxxxxx> wrote:
>
> On Tue, Mar 31, 2026 at 10:59 PM Miguel Ojeda <ojeda@xxxxxxxxxx> wrote:
> >
> > Clippy in Rust 1.88.0 (only) reported [1] up to the previous commit:
> >
> >     warning: variables can be used directly in the `format!` string
> >        --> rust/macros/module.rs:112:23
> >         |
> >     112 |         let content = format!("{param}:{content}", param = param, content = content);
> >         |                       ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
> >         |
> >         = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
> >         = note: `-W clippy::uninlined-format-args` implied by `-W clippy::all`
> >         = help: to override `-W clippy::all` add `#[allow(clippy::uninlined_format_args)]`
> >     help: change this to
> >         |
> >     112 -         let content = format!("{param}:{content}", param = param, content = content);
> >     112 +         let content = format!("{param}:{content}");
> >
> > The reason it only triggers in that version is that the lint was moved
> > from `pedantic` to `style` in Rust 1.88.0 and then back to `pedantic`
> > in Rust 1.89.0 [2][3].
> >
> > In this case, the suggestion is fair and a pure simplification, thus
> > just apply it.
> >
> > In addition, do the same for another place in the file that Clippy does
> > not report because it is multi-line.
> >
> > Link: https://lore.kernel.org/rust-for-linux/CANiq72=drAtf3y_DZ-2o4jb6Az9J3Yj4QYwWnbRui4sm4AJD3Q@xxxxxxxxxxxxxx/ [1]
> > Link: https://github.com/rust-lang/rust-clippy/pull/15287 [2]
> > Link: https://github.com/rust-lang/rust-clippy/issues/15151 [3]
> > Signed-off-by: Miguel Ojeda <ojeda@xxxxxxxxxx>
>
> I will pick this one up together with the other one, but if someone
> prefers that I don't, please shout (e.g. if modules wants to pick it
> themselves).

Sounds good to me, thanks.

> An Acked-by is also appreciated, thanks!

Acked-by: Sami Tolvanen <samitolvanen@xxxxxxxxxx>

Sami