Re: [PATCH v2 4/4] drivers: hv: mark channel attributes as const

From: Thomas Weißschuh

Date: Fri Apr 03 2026 - 12:34:40 EST


On 2026-04-03 15:56:54+0000, Michael Kelley wrote:
> From: Thomas Weißschuh <linux@xxxxxxxxxxxxxx> Sent: Friday, April 3, 2026 1:29 AM
> >
> > These attributes are never modified, mark them as const.
> >
> > Signed-off-by: Thomas Weißschuh <linux@xxxxxxxxxxxxxx>
> > Tested-by: Michael Kelley <mhklinux@xxxxxxxxxxx>
>
> Reviewed-by: Michael Kelley <mhklinux@xxxxxxxxxxx>

Thanks.

> But take a look at this analysis from Sashiko AI:
> https://sashiko.dev/#/patchset/20260403-sysfs-const-hv-v2-0-8932ab8d41db%40weissschuh.net
>
> This seems to be a valid concern with your earlier commit 7dd9fdb4939b9
> "sysfs: attribute_group: enable const variants of is_visible()".

Indeed, I missed this user of ->is_visible.
I'll send a fix for that, but it shouldn't affect this series.


Thomas