RE: [PATCh v3 03/14] ASoC: rsnd: Add reset controller support to rsnd_mod

[John Madieu]

Hi Mark,

Thanks for your review.

> -----Original Message-----
> From: Mark Brown <broonie@xxxxxxxxxx>
> Sent: Thursday, April 2, 2026 7:39 PM
> To: John Madieu <john.madieu.xa@xxxxxxxxxxxxxx>
> Subject: Re: [PATCh v3 03/14] ASoC: rsnd: Add reset controller support to
> rsnd_mod
> 
> On Thu, Apr 02, 2026 at 06:24:25PM +0200, John Madieu wrote:
> 
> > @@ -196,18 +197,29 @@ int rsnd_mod_init(struct rsnd_priv *priv,
> 
> > +	ret = reset_control_deassert(rstc);
> > +	if (ret) {
> > +		clk_disable_unprepare(clk);
> > +		return ret;
> > +	}
> 
> I'm not seeing a call to reverse this anywhere, I'd expect one on remove
> for symmetry and safety.

You are right. I'll address that with reset_control_assert() in
rsnd_mod_quit() to mirror the deassert done in init.

Regards,
John