Re: [PATCH] staging: rtl8723bs: simplify xmit_frame initialization

[Greg KH]

On Fri, Apr 03, 2026 at 12:13:07AM +0000, Hungyu Lin wrote:
> Simplify initialization of pframe by combining declaration and
> assignment, improving readability.
> 
> No functional change.
> 
> Signed-off-by: Hungyu Lin <dennylin0707@xxxxxxxxx>
> ---
>  drivers/staging/rtl8723bs/hal/rtl8723bs_xmit.c | 5 +++--
>  1 file changed, 3 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/staging/rtl8723bs/hal/rtl8723bs_xmit.c b/drivers/staging/rtl8723bs/hal/rtl8723bs_xmit.c
> index a1f2cbf2cf55..84e58e53d708 100644
> --- a/drivers/staging/rtl8723bs/hal/rtl8723bs_xmit.c
> +++ b/drivers/staging/rtl8723bs/hal/rtl8723bs_xmit.c
> @@ -239,8 +239,9 @@ static s32 xmit_xmitframes(struct adapter *padapter, struct xmit_priv *pxmitpriv
>  						/* pxmitbuf->priv_data will be NULL, and will crash here */
>  						if (pxmitbuf->len > 0 &&
>  						    pxmitbuf->priv_data) {
> -							struct xmit_frame *pframe;
> -							pframe = (struct xmit_frame *)pxmitbuf->priv_data;
> +							struct xmit_frame *pframe =
> +								pxmitbuf->priv_data;
> +

This is now 3 lines, not 2, which didn't really help anything out in
looking better.

What tool told you to make this change?  It needs to be fixed.

thanks,

greg k-h