RE: [PATCh v3 10/14] ASoC: rsnd: adg: Add per-SSI ADG and SSIF supply clock management

[John Madieu]

Hi Mark,

Thanks for your review.

> -----Original Message-----
> From: Mark Brown <broonie@xxxxxxxxxx>
> Sent: Thursday, April 2, 2026 8:03 PM
> To: John Madieu <john.madieu.xa@xxxxxxxxxxxxxx>
> Subject: Re: [PATCh v3 10/14] ASoC: rsnd: adg: Add per-SSI ADG and SSIF
> supply clock management
> 
> On Thu, Apr 02, 2026 at 06:24:32PM +0200, John Madieu wrote:
> 
> > @@ -376,6 +431,18 @@ int rsnd_adg_ssi_clk_try_start(struct rsnd_mod
> *ssi_mod, unsigned int rate)
> >  		(ckr) ?	adg->brg_rate[ADG_HZ_48] :
> >  			adg->brg_rate[ADG_HZ_441]);
> >
> > +	/*
> > +	 * RZ/G3E: enable per-SSI and supply clocks
> > +	 * Prepare was done in hw_params
> > +	 */
> > +	ret = clk_enable(adg->clk_adg_ssi[id]);
> > +	if (ret)
> > +		dev_warn(dev, "Cannot enable adg.ssi.%d ADG clock\n", id);
> > +
> > +	ret = clk_enable(adg->clk_ssif_supply);
> > +	if (ret)
> > +		dev_warn(dev, "Cannot enable SSIF supply clock\n");
> > +
> 
> Should we not return an error if we can't start the clocks for some
> reason?

Agreed.
I'll return proper errors with cleanup on clk_enable() failure.

Regards,
John