RE: [PATCh v3 10/14] ASoC: rsnd: adg: Add per-SSI ADG and SSIF supply clock management

[John Madieu]

Hi Mark,

Thanks for the review.

> -----Original Message-----
> From: Mark Brown <broonie@xxxxxxxxxx>
> Sent: Thursday, April 2, 2026 8:06 PM
> To: John Madieu <john.madieu.xa@xxxxxxxxxxxxxx>
> Subject: Re: [PATCh v3 10/14] ASoC: rsnd: adg: Add per-SSI ADG and SSIF
> supply clock management
> 
> On Thu, Apr 02, 2026 at 06:24:32PM +0200, John Madieu wrote:
> 
> >
> > +/*
> > + * RZ/G3E: Prepare SSI clocks - call from hw_params (can sleep)  */
> > +int rsnd_adg_ssi_clk_prepare(struct rsnd_mod *ssi_mod) {
> 
> > +	ret = clk_prepare(adg->clk_adg_ssi[id]);
> 
> One other issue here: hw_params() can be called multiple times without
> starting a stream, this might lead to leaks of clk_prepare().

Thanks for letting me know. I'll address that when implementing what
Koninori has suggested. This should normally not be an issue anymore in
v4.

Regards,
John