Re: [PATCH v2] netfilter: xt_HL: add pr_fmt, drop NULL checks, add checkentry validation

[Jacob Keller]

On 4/3/2026 1:03 PM, Marino Dzalto wrote:
> Add pr_fmt for module-prefixed log messages. Remove unnecessary NULL
> checks for skb, as netfilter core guarantees skb is non-NULL. Add
> checkentry functions to validate match mode at rule registration time.
> 

The patch is small so I guess its not a huge deal, but this feels like 3
patches in a trench coat to me. The pr_fmt makes sense to combine, and
the actual patch content just appears to be implementing the .checkentry
callbacks. Seems like this description could use a little update.

> Signed-off-by: Marino Dzalto <marino.dzalto@xxxxxxxxx>
> ---
>  net/netfilter/xt_hl.c | 27 +++++++++++++++++++++++++++
>  1 file changed, 27 insertions(+)
> 

The patch also says it removes unnecessary NULL checks. But how is that
even possible when there are no removal lines in the diff? Is that a
leftover from the previous version?

Thanks,
Jake