Re: [PATCH v3 1/2] rust: sizes: add DeviceSize trait for device address space constants

From: John Hubbard

Date: Fri Apr 03 2026 - 21:47:08 EST


On 4/3/26 6:07 AM, Danilo Krummrich wrote:
...
>> Anyway, I'm pretty sold on SizeConstants, so I'm hoping to stay with
>> that, are you OK with it?
>
> As mentioned no complaints from my side, but I think it would be good to add a
> TODO for creating those type wrappers; the name can be revisited in this context
> or a separate marker trait introduced.

OK. It's a little too "future design idea" for a code TODO, but
it fits nicely into Documentation/gpu/nova/core/todo.rst, so I've
added a PATCH 3/3 for that.

thanks,
--
John Hubbard