Re: [PATCH] staging: media: atomisp: pci: cleanup and refactor tracing functions

[Даниил Булгарь]

Hi Andy,

Thank you for the feedback.

I have fixed the commit message formatting (resolved the 'shorty
lines' and improved the description) in v2.

Regarding the removal of enter/leave traces: I have verified that
these specific logs did not carry any dynamic data or state variables.
Since the kernel's ftrace (function_graph) already tracks function
boundaries automatically, these manual prints were redundant. In the
remaining logs that do contain useful data, I have kept the
information but switched to using func for better maintainability.

I am sending the v2 patch shortly.

сб, 4 апр. 2026 г. в 21:51, Andy Shevchenko <andriy.shevchenko@xxxxxxxxx>:
>
> On Sat, Apr 04, 2026 at 02:16:58PM +0200, Daniil Bulgar wrote:
> > The current tracing in sh_css.c contains
> > ftrace-like enter/leave logs that clutter
> > the code and provide little diagnostic value.
> > This patch removes these redundant traces and
> > updates the remaining useful logs
> > to use __func__ for better maintainability.
>
> It's too shorty lines.
>
> ...
>
> Do you have output before and after to compare?
>
>
> --
> With Best Regards,
> Andy Shevchenko
>
>