Re: [PATCH 1/3] dt-bindings: pinctrl: describe the TLMM controller on Qualcomm Nord platforms

[Krzysztof Kozlowski]

On Fri, Apr 03, 2026 at 03:27:55PM +0200, Bartosz Golaszewski wrote:
> Add a DT binding document describing the TLMM pin controller available
> on the Nord platforms from Qualcomm.

That's the first time name Nord appears on the lists (except OnePlus
Nord!) and I do not see soc-info with explanation. I know what the Nord
is, but others might not, and if I complain to other patchsets that way
I should complain also here.

The easiest is to send soc-info patch with explanations before this one.

> 
> Co-developed-by: Shawn Guo <shengchao.guo@xxxxxxxxxxxxxxxx>
> Signed-off-by: Shawn Guo <shengchao.guo@xxxxxxxxxxxxxxxx>
> Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@xxxxxxxxxxxxxxxx>
> ---
>  .../bindings/pinctrl/qcom,nord-tlmm.yaml           | 206 +++++++++++++++++++++
>  1 file changed, 206 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/pinctrl/qcom,nord-tlmm.yaml b/Documentation/devicetree/bindings/pinctrl/qcom,nord-tlmm.yaml
> new file mode 100644
> index 0000000000000000000000000000000000000000..b1fdaa24a045469e3dec512ce0200f240daa1959
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/pinctrl/qcom,nord-tlmm.yaml
> @@ -0,0 +1,206 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/pinctrl/qcom,nord-tlmm.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Qualcomm Technologies, Inc. Nord TLMM block
> +
> +maintainers:
> +  - Bartosz Golaszewski <brgl@xxxxxxxxxx>
> +
> +description: |

Drop |

> +  Top Level Mode Multiplexer pin controller in Qualcomm Nord SoC.
> +
> +allOf:
> +  - $ref: /schemas/pinctrl/qcom,tlmm-common.yaml#
> +
> +properties:
> +  compatible:
> +    const: qcom,nord-tlmm
> +
> +  reg:
> +    maxItems: 1
> +
> +  interrupts:
> +    maxItems: 1
> +
> +  gpio-reserved-ranges:
> +    minItems: 1
> +    maxItems: 74

I guess rather 90 (half of gpios could be reserved in theory...)

> +
> +  gpio-line-names:
> +    maxItems: 180

pattern in "pins" says 181 gpios.

> +
> +patternProperties:
> +  "-state$":
> +    oneOf:
> +      - $ref: "#/$defs/qcom-nord-tlmm-state"
> +      - patternProperties:
> +          "-pins$":
> +            $ref: "#/$defs/qcom-nord-tlmm-state"
> +        additionalProperties: false
> +
> +$defs:
> +  qcom-nord-tlmm-state:
> +    type: object
> +    description:
> +      Pinctrl node's client devices use subnodes for desired pin configuration.
> +      Client device subnodes use below standard properties.
> +    $ref: qcom,tlmm-common.yaml#/$defs/qcom-tlmm-state
> +    unevaluatedProperties: false
> +
> +    properties:
> +      pins:
> +        description:
> +          List of gpio pins affected by the properties specified in this
> +          subnode.
> +        items:
> +          oneOf:
> +            - pattern: "^gpio([0-9]|[1-9][0-9]|1[0-7][0-9]|180])$"

Best regards,
Krzysztof