Re: [PATCH v2 2/3] gpu: nova-core: fb: fix clippy::precedence warning in read_sysmem_flush_page_ga100()
From: Alexandre Courbot
Date: Sun Apr 05 2026 - 07:42:53 EST
On Sun Apr 5, 2026 at 6:35 AM JST, John Hubbard wrote:
> On 4/4/26 2:28 PM, John Hubbard wrote:
>> Clippy warns when shifts and bitwise-OR are mixed without parentheses,
>> because the relative precedence of << and | is easy to misread.
>>
>> Add explicit parentheses to silence the warning.
>
> Please disregard (drop) this patch 2/3, because Miguel is removing
> the associated lint, so we won't need it.
I'm tempted to consider it anyway, because it is a readability
improvement. Any objection?