Re: [PATCH net v2] tg3: Add PowerEdge R740xd to AER quirk list

From: Andrew Lunn

Date: Sun Apr 05 2026 - 19:49:36 EST


On Sun, Apr 05, 2026 at 12:56:11PM +0200, Oskar Ray-Frayssinet wrote:
> On Sun, Apr 05, 2026 at 01:03:00AM +0200, Andrew Lunn wrote:
> > When you look at tg3_restart_aer_quirk_table[] they are all Dell.
> > Are there any Dell systems which actually work? Would it make sense
> > to mark all Dell systems as broken and enable the quirk?
>
> That's a good point. I don't know if there are Dell systems where
> the quirk would cause harm. Do you know if it's safe to apply the
> quirk to all Dell systems, or should we be cautious and keep the
> per-model approach?

You might want to ask on the PCI list.

As far as i see, with 30 seconds for searching and reading
documentation, AER, Advanced Error Reporting is an optional feature of
PCIe. Since it is optional, it seems like disabling it during shutdown
should not have any negative effects. Except for systems where it
actually works, and there are real errors during shutdown and
resume. It will be harder to debug such errors since you don't get the
advanced error report.

Andrew