Re: [PATCh v3 07/14] ASoC: rsnd: ssui: Add RZ/G3E SSIU BUSIF support

[Kuninori Morimoto]

Hi John

> > > -	for (i = 0; i < 4; i++) {
> > > +	for (unsigned int i = 0; i < priv->ssiu_busif_count; i++) {
> > >  		u32 reg = SSI_SYS_STATUS(i * 2) + offset;
> > >  		u32 status = rsnd_mod_read(mod, reg);
> > >  		u32 val = 0xf << (shift * 4);
> > 
> > ssiu_busif_count is for SSIU specific, no need to have it on priv.
> > Please move it on rsnd_ssiu.
> 
> Agreed. However, since this is per-SoC, I would rather use a
> file-static variable, rather thatn per ssiu instance in rsnd_ssiu.
> I hope this is fine for you.

>From "meaning" point of view, both inside/outside ssiu instance are OK.
But I don't like to have it as file-static. Because it could be
overlookooked if some kind of updated was required around here in the
future (= people will consider ssiu instance).
Unless there is absolutely necessary, please keep current style.

Thank you for your help !!

Best regards
---
Kuninori Morimoto