Re: [PATCH 3/3] hwmon: (gpd-fan): rename enum constants to uppercase as per kernel coding style
From: Pei Xiao
Date: Sun Apr 05 2026 - 20:58:57 EST
在 2026/4/5 21:53, Guenter Roeck 写道:
> On 4/5/26 01:40, Pei Xiao wrote:
>> Kernel coding style requires enum labels to be capitalized. Convert all
>> enum gpd_board constants from lowercase to uppercase.
>>
>
> While this may be the case, the hardware monitoring subsystem traditionally
> uses lowercase for chip/board/system types. Changing that would be a
> tremendous task, disrupting, confusing, create a flurry of patches, make
> back-ports more difficult, and it would be completely unnecessary.
>
Yes, follow history. This will waste everyone's time.
> NACK.
>
> Guenter
>
>> Signed-off-by: Pei Xiao <xiaopei01@xxxxxxxxxx>
>> ---
>> drivers/hwmon/gpd-fan.c | 62 ++++++++++++++++++++---------------------
>> 1 file changed, 31 insertions(+), 31 deletions(-)
>>
>> diff --git a/drivers/hwmon/gpd-fan.c b/drivers/hwmon/gpd-fan.c
>> index 7df46027177d..404155dd97bb 100644
>> --- a/drivers/hwmon/gpd-fan.c
>> +++ b/drivers/hwmon/gpd-fan.c
>> @@ -27,11 +27,11 @@ static char *gpd_fan_board = "";
>> module_param(gpd_fan_board, charp, 0444);
>> enum gpd_board {
>> - win_mini,
>> - win4_6800u,
>> - win_max_2,
>> - duo,
>> - mpc2,
>> + GPD_WIN_MINI,
>> + GPD_WIN4_6800U,
>> + GPD_WIN_MAX_2,
>> + GPD_DUO,
>> + GPD_MPC2,
>> };
>> enum FAN_PWM_ENABLE {
>> @@ -60,7 +60,7 @@ struct gpd_fan_drvdata {
>> static struct gpd_fan_drvdata gpd_win_mini_drvdata = {
>> .board_name = "win_mini",
>> - .board = win_mini,
>> + .board = GPD_WIN_MINI,
>> .addr_port = 0x4E,
>> .data_port = 0x4F,
>> @@ -72,7 +72,7 @@ static struct gpd_fan_drvdata gpd_win_mini_drvdata = {
>> static struct gpd_fan_drvdata gpd_duo_drvdata = {
>> .board_name = "duo",
>> - .board = duo,
>> + .board = GPD_DUO,
>> .addr_port = 0x4E,
>> .data_port = 0x4F,
>> @@ -84,7 +84,7 @@ static struct gpd_fan_drvdata gpd_duo_drvdata = {
>> static struct gpd_fan_drvdata gpd_win4_drvdata = {
>> .board_name = "win4",
>> - .board = win4_6800u,
>> + .board = GPD_WIN4_6800U,
>> .addr_port = 0x2E,
>> .data_port = 0x2F,
>> @@ -96,7 +96,7 @@ static struct gpd_fan_drvdata gpd_win4_drvdata = {
>> static struct gpd_fan_drvdata gpd_wm2_drvdata = {
>> .board_name = "wm2",
>> - .board = win_max_2,
>> + .board = GPD_WIN_MAX_2,
>> .addr_port = 0x4E,
>> .data_port = 0x4F,
>> @@ -108,7 +108,7 @@ static struct gpd_fan_drvdata gpd_wm2_drvdata = {
>> static struct gpd_fan_drvdata gpd_mpc2_drvdata = {
>> .board_name = "mpc2",
>> - .board = mpc2,
>> + .board = GPD_MPC2,
>> .addr_port = 0x4E,
>> .data_port = 0x4F,
>> @@ -322,12 +322,12 @@ static int gpd_wm2_read_rpm(struct gpd_fan_data *data)
>> static int gpd_read_rpm(struct gpd_fan_data *data)
>> {
>> switch (data->drvdata->board) {
>> - case win4_6800u:
>> - case win_mini:
>> - case duo:
>> - case mpc2:
>> + case GPD_WIN4_6800U:
>> + case GPD_WIN_MINI:
>> + case GPD_DUO:
>> + case GPD_MPC2:
>> return gpd_generic_read_rpm(data);
>> - case win_max_2:
>> + case GPD_WIN_MAX_2:
>> return gpd_wm2_read_rpm(data);
>> }
>> @@ -349,10 +349,10 @@ static int gpd_wm2_read_pwm(struct gpd_fan_data *data)
>> static int gpd_read_pwm(struct gpd_fan_data *data)
>> {
>> switch (data->drvdata->board) {
>> - case win_mini:
>> - case duo:
>> - case win4_6800u:
>> - case mpc2:
>> + case GPD_WIN_MINI:
>> + case GPD_DUO:
>> + case GPD_WIN4_6800U:
>> + case GPD_MPC2:
>> switch (data->pwm_enable) {
>> case DISABLE:
>> return 255;
>> @@ -362,7 +362,7 @@ static int gpd_read_pwm(struct gpd_fan_data *data)
>> return -EOPNOTSUPP;
>> }
>> break;
>> - case win_max_2:
>> + case GPD_WIN_MAX_2:
>> return gpd_wm2_read_pwm(data);
>> }
>> return 0;
>> @@ -400,13 +400,13 @@ static int gpd_write_pwm(struct gpd_fan_data *data, u8 val)
>> return -EPERM;
>> switch (data->drvdata->board) {
>> - case duo:
>> + case GPD_DUO:
>> gpd_duo_write_pwm(data, val);
>> break;
>> - case win_mini:
>> - case win4_6800u:
>> - case win_max_2:
>> - case mpc2:
>> + case GPD_WIN_MINI:
>> + case GPD_WIN4_6800U:
>> + case GPD_WIN_MAX_2:
>> + case GPD_MPC2:
>> gpd_generic_write_pwm(data, val);
>> break;
>> }
>> @@ -472,15 +472,15 @@ static void gpd_set_pwm_enable(struct gpd_fan_data *data, enum FAN_PWM_ENABLE en
>> data->pwm_value = 255;
>> switch (data->drvdata->board) {
>> - case win_mini:
>> - case win4_6800u:
>> - case mpc2:
>> + case GPD_WIN_MINI:
>> + case GPD_WIN4_6800U:
>> + case GPD_MPC2:
>> gpd_win_mini_set_pwm_enable(data, enable);
>> break;
>> - case duo:
>> + case GPD_DUO:
>> gpd_duo_set_pwm_enable(data, enable);
>> break;
>> - case win_max_2:
>> + case GPD_WIN_MAX_2:
>> gpd_wm2_set_pwm_enable(data, enable);
>> break;
>> }
>> @@ -605,7 +605,7 @@ static void gpd_init_ec(struct gpd_fan_data *data)
>> // Before its initialization, reading RPM will always return 0,
>> // and writing PWM will have no effect.
>> // Initialize it manually on driver load.
>> - if (data->drvdata->board == win4_6800u)
>> + if (data->drvdata->board == GPD_WIN4_6800U)
>> gpd_win4_init_ec(data);
>> }
>>